(fix) O3-4270: Group obs by encounter instead of datetime #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -41.4 kB (-0.26%) Total Size: 16 MB
ℹ️ View Unchanged
|
vasharma05
changed the title
issued datetime
brandones
changed the title
brandones
reviewed
Dec 15, 2024
packages/esm-generic-patient-widgets-app/src/obs-table/obs-table.component.tsx
Outdated
Show resolved
Hide resolved
|
@vasharma05 We may as well group by the encounter datetime, even though this won't necessarily align with the effective date of the obs, but since each obs can have it's own effective date, I don't see how we could get the right "logical" grouping. Maybe we put the obs effective date in a tooltip or something? |
Actually, the obs effective date is what is being shown under the |
…ient-chart into fix/group-obs-by-encounter
brandones
approved these changes
Dec 19, 2024
|
Please fix the conflict and CI, and then you should be good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR makes a change in the
obs-by-encounter-widget. Initially, the obs were grouped with the obs' issued date time. The issue with the above approach is that a new row in the table is created when the obs value is updated.The
obsshould be grouped by encounter rather than date and time, is because the obs are recorded as part of an encounter. Even if we groupobsby time, the obs recorded together (as part of an encounter) will be grouped together, hence it makes sense to group the obs by related encounter, rather than recorded time.Screenshots
Configuration
Before
Screen.Recording.2024-12-12.at.19.02.42.mov
After
Related Issue
https://openmrs.atlassian.net/browse/O3-4270
Other