(test) O3-4177: Add E2E test for adding abnormal vitals #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @kdaud @ODORA0 @jayasanka-sack Please review this. Thanks |
NethmiRodrigo
changed the title
NethmiRodrigo
changed the title
kdaud
reviewed
Dec 11, 2024
e2e/specs/invalid.vitals.spec.ts
Outdated
| await expect(biometricsPage.page.getByText(/record vitals and biometrics/i)).toBeVisible(); | ||
| }); | ||
|
|
||
| await test.step('When the user enters abnormal vitals/biometric values', async () => { |
There was a problem hiding this comment.
Is the test for vitals or biometrics?
There was a problem hiding this comment.
Shall we break down each value into sub steps? Generic steps can be confusing since they don't show what information was filled in the form.
There was a problem hiding this comment.
Please review again @jayasanka-sack , Thank you
jayasanka-sack
changed the title
jayasanka-sack
changed the title
jayasanka-sack
requested changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
E2E test for invalid vitals
https://openmrs.atlassian.net/browse/O3-4177
Reference
Screenshots
Related Issue
Other