Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(test) O3-4227: Add E2E Test for Marking an Existing Patient as Deceased #2129

Open
wants to merge 49 commits into
base: main
Choose a base branch
from

Conversation

virajwathsalag
Copy link
Contributor

@virajwathsalag virajwathsalag commented Dec 4, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Create an automated test to verify the functionality of marking an existing patient as deceased. This test will ensure that the process works as expected and that the patient's record is correctly updated with the death details.

Screenshots

Related Issue

Ticket Link : https://openmrs.atlassian.net/issues/O3-4227

Other

@brandones
Copy link
Contributor

Hi @virajwathsalag , it looks like the E2E tests aren't passing. Could you get them passing, please?

@virajwathsalag
Copy link
Contributor Author

@brandones Okay sure

@virajwathsalag
Copy link
Contributor Author

@jayasanka-sack @brandones could you please check this PR

Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @virajwathsalag ! I left some comments, please have a look.

e2e/specs/mark-patient-deceased.spec.ts Outdated Show resolved Hide resolved
e2e/pages/mark-patient-deceased-page.ts Outdated Show resolved Hide resolved
e2e/pages/mark-patient-deceased-page.ts Outdated Show resolved Hide resolved
e2e/pages/mark-patient-deceased-page.ts Show resolved Hide resolved
e2e/specs/mark-patient-deceased.spec.ts Outdated Show resolved Hide resolved
e2e/specs/mark-patient-deceased.spec.ts Outdated Show resolved Hide resolved
e2e/specs/mark-patient-deceased.spec.ts Outdated Show resolved Hide resolved
e2e/specs/mark-patient-deceased.spec.ts Outdated Show resolved Hide resolved
e2e/specs/mark-patient-deceased.spec.ts Outdated Show resolved Hide resolved
e2e/specs/mark-patient-deceased.spec.ts Show resolved Hide resolved
e2e/specs/mark-patient-deceased.spec.ts Outdated Show resolved Hide resolved
e2e/specs/mark-patient-deceased.spec.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@NethmiRodrigo NethmiRodrigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @virajwathsalag! there's one place where you've missed breaking down the steps:

e2e/specs/mark-patient-deceased.spec.ts Outdated Show resolved Hide resolved
@NethmiRodrigo NethmiRodrigo changed the title (chore) O3-4227: Add E2E Test for Marking an Existing Patient as Deceased (test) O3-4227: Add E2E Test for Marking an Existing Patient as Deceased Dec 19, 2024
Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @virajwathsalag. Getting close!
Please take a look at my updated comments and questions.

e2e/specs/mark-patient-deceased.spec.ts Outdated Show resolved Hide resolved
e2e/specs/mark-patient-deceased.spec.ts Outdated Show resolved Hide resolved
e2e/specs/mark-patient-deceased.spec.ts Outdated Show resolved Hide resolved
e2e/specs/mark-patient-deceased.spec.ts Outdated Show resolved Hide resolved
e2e/specs/mark-patient-deceased.spec.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants