Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/O3-3983: Allow Same-Day Program Enrollment and Completion #2039

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jwnasambu
Copy link
Contributor

@jwnasambu jwnasambu commented Sep 26, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

I fixed the minimum selectable date for the completion date in the date picker to equal to the enrollment date set to midnight preventing the selection of an invalid date range where a completion date could occur before the enrollment date. I also modified the schema to allow completionDate to be equal to enrollmentDate.

Screenshots

screencast.2024-09-27.12.AM-42-50.mp4

Related Issue

https://openmrs.atlassian.net/browse/O3-3983

Other

@jwnasambu
Copy link
Contributor Author

@brandones, @denniskigen, @ibacher I kindly request your guidance to ensure that the form is submitted successfully.

@jwnasambu jwnasambu marked this pull request as draft September 27, 2024 14:12
@jwnasambu jwnasambu marked this pull request as ready for review October 11, 2024 09:05
@brandones
Copy link
Contributor

What's the status of this?

@denniskigen denniskigen self-assigned this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants