Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OHRI-2033 Fix the overlapping text issue for the repeating obs-group #157

Closed
wants to merge 1 commit into from

Conversation

CynthiaKamau
Copy link
Contributor

@CynthiaKamau CynthiaKamau commented Dec 19, 2023

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

  • Fix the overlapping text issue for the repeating obs-group

Screenshots

https://www.loom.com/share/06b0e88276904352801ef0340187c965?sid=0732c40d-6c57-4075-91b7-0e7aa64cee4f

Related Issue

Other

Copy link

github-actions bot commented Dec 19, 2023

Size Change: +24 B (0%)

Total Size: 1.04 MB

ℹ️ View Unchanged
Filename Size Change
dist/125.js 89.8 kB 0 B
dist/225.js 9.82 kB 0 B
dist/272.js 6.59 kB 0 B
dist/294.js 2.63 kB 0 B
dist/340.js 189 kB 0 B
dist/366.js 6.94 kB 0 B
dist/379.js 236 kB +14 B (0%)
dist/612.js 6.59 kB 0 B
dist/709.js 2.42 kB 0 B
dist/787.js 822 B 0 B
dist/800.js 175 kB 0 B
dist/main.js 316 kB +10 B (0%)
dist/openmrs-form-engine-lib.js 3.22 kB 0 B

compressed-size-action

@@ -23,11 +23,13 @@
/** Targets carbon's multiselect */
.obsGroupColumn > div > div > div {
max-width: 18rem !important;
margin-right: 3rem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For obs group, anything below 2.8rem will overlap with the previous values

@pirupius pirupius deleted the 2033 branch March 11, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants