Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-2822 Hide the tiles on the billing services management page #4

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

ODORA0
Copy link
Member

@ODORA0 ODORA0 commented Feb 7, 2024

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

Other

@ODORA0 ODORA0 marked this pull request as draft February 7, 2024 10:29
@ODORA0 ODORA0 requested a review from pirupius February 7, 2024 10:56
@@ -35,6 +36,7 @@ export default function ServiceMetrics() {
{cards.map((card) => (
<Card key={card.title} title={card.title} count={card.count} />
))}
<ExtensionSlot name="billing-home-tiles-slot" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ODORA0 , i think you could add a config to enable people who want to hide the tiles to do so

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CynthiaKamau Wouldn't having this as an extension still makes it configurable for any usecase?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it would, i guess people who dont want it can do it in their config

@ODORA0 ODORA0 marked this pull request as ready for review February 8, 2024 07:35
@pirupius pirupius merged commit b92b8c2 into openmrs:main Feb 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants