Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-2911 Remove Uncaught Error: Minified React error #310 on the Billi… #19

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

CynthiaKamau
Copy link
Contributor

…ng Module

Requirements

  • This PR has a title that briefly describes the work done including a conventional commit type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.

Summary

  • Edit convertToCurrency function to accept currency as param instead of fetching it from config. This was causing a react minified error because the component is rendered before the useConfig hook has had a chance to fetch or provide the configuration data to the function.

Screenshots

Screen.Recording.2024-03-05.at.14.33.04.mov

Related Issue

Other

@CynthiaKamau CynthiaKamau requested review from denniskigen and ODORA0 and removed request for denniskigen March 5, 2024 12:10
@CynthiaKamau CynthiaKamau merged commit 1594307 into main Mar 6, 2024
5 checks passed
@pirupius pirupius deleted the O3-2911 branch March 14, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants