Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-5836: ConceptDatatype Domain - Switching from Hibernate Mappings to Annotations #4854

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

rishabhrawat05
Copy link

TRUNK-5836: ConceptDatatype Domain - Switching from Hibernate Mappings to Annotations

Description of what I changed

Switched ConceptDatatype Hibernate Mapping to Annotations

Issue I worked on

https://issues.openmrs.org/browse/TRUNK-5836

see https://issues.openmrs.org/browse/TRUNK-

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@rishabhrawat05 rishabhrawat05 changed the title Switched ConceptDatatype Hibernate Mapping to Annotations TRUNK-5836: ConceptDatatype Domain - Switching from Hibernate Mappings to Annotations Dec 1, 2024
@ManojLL
Copy link
Contributor

ManojLL commented Dec 1, 2024

@rishabhrawat05 Thanks for the PR, you should remove ConceptDatatype.hbm.xml file.

@rishabhrawat05
Copy link
Author

Hey! @ManojLL I have removed the ConceptDatatype file

@rishabhrawat05
Copy link
Author

Hey! @ManojLL
The changes that are requested have been made. Please review the changes

@ManojLL
Copy link
Contributor

ManojLL commented Dec 3, 2024

@wikumChamith @dkayiwa can you have a look on this PR?

Copy link
Contributor

@ManojLL ManojLL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishabhrawat05 please check the build fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants