Add OSX Support #115
Add OSX Support #115
Conversation
|
@mikemhenry could you please trigger the CI here? The tests are all passing on my fork so this should be ready for review. |
.github/workflows/ci.yml
Outdated
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
|
|
||
| # Oldest supported versions | ||
| - name: Linux (CUDA 10.2, Python 3.8, PyTorch 1.11) | ||
| os: ubuntu-18.04 |
There was a problem hiding this comment.
Why go back to ubuntu-18 from 22?
There was a problem hiding this comment.
🤦 good catch, thanks! fixed in 5b4051a
.github/workflows/ci.yml
Outdated
| - name: Prepare dependencies (Mac) | ||
| if: ${{ contains(matrix.os, 'macos') }} | ||
| run: | | ||
| sed -i '' -e "s/- cudatoolkit/# - cudatoolkit/" \ |
There was a problem hiding this comment.
It really looks like you are trying to install cudatoolkit here in OSX.
Not sure how to make it more obvious that you are commenting out the line.
Perhaps sed -i '' "/- cudatoolkit/d"
There was a problem hiding this comment.
hmm yeah I see what you mean! this should be swapped over in 4014ff4
| if: ${{ contains(matrix.os, 'macos') }} | ||
| run: | | ||
| sed -i '' -e "/- cudatoolkit/d" \ | ||
| -e "/- gxx_linux-64/d" \ |
There was a problem hiding this comment.
You dont need to install some version of gxx for Mac?
|
@peastman, I believe someone has to manually allow the new CI to run. Could you do so? |
|
It already ran without me doing anything. Two builds failed, one from CUDA not being available and one from running out of disk space. |
|
CUDA builds seem unrelated to this PR. |
Hmm strange... can someone re-trigger the CI to see if this failure was a one off due to some runner issue?
Sure I can swap to conda distributed compilers if you'd prefer - should be swapped in 1794c6e |
This PR updates how the custom ops lib is loaded to support OSX (and in theory Windows), and enables OSX tests in the CI
Fixes #102
Fixes #62