Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OSX #27

Merged
merged 7 commits into from
Oct 14, 2023
Merged

Add support for OSX #27

merged 7 commits into from
Oct 14, 2023

Conversation

SimonBoothroyd
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@SimonBoothroyd
Copy link
Contributor Author

@conda-forge-admin, please rerender

@SimonBoothroyd
Copy link
Contributor Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits October 14, 2023 13:23
@SimonBoothroyd
Copy link
Contributor Author

@conda-forge-admin, please rerender

@SimonBoothroyd SimonBoothroyd marked this pull request as ready for review October 14, 2023 14:12
@SimonBoothroyd
Copy link
Contributor Author

Looks like all the tests are coming back green, so this should be ready for review!

The patch should only need to be temporary until openmm/NNPOps#115 is resolved

RaulPPelaez
RaulPPelaez approved these changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@RaulPPelaez RaulPPelaez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you so much! We are not really familiar with OSX so we had not gotten around this.

Have you tested locally with a GPU?

@SimonBoothroyd
Copy link
Contributor Author

Thanks! As far as I know CUDA isn't available on OSX, but when I tested the non-CUDA build locally with this patch it seemed to work great!

@RaulPPelaez
Copy link
Contributor

Oh right, I confused this with your NNPOps PR openmm/NNPOps#115

@RaulPPelaez RaulPPelaez merged commit 15cf57a into conda-forge:main Oct 14, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaulPPelaez RaulPPelaez RaulPPelaez approved these changes

@h-vetinari h-vetinari Awaiting requested review from h-vetinari h-vetinari is a code owner

@mikemhenry mikemhenry Awaiting requested review from mikemhenry mikemhenry is a code owner

@raimis raimis Awaiting requested review from raimis raimis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonBoothroyd @RaulPPelaez