Skip to content

Commit

Permalink
Add missing parameters to volume functions
Browse files Browse the repository at this point in the history
Signed-off-by: Eric Bischoff <[email protected]>
  • Loading branch information
Bischoff committed Nov 19, 2024
1 parent 106de3b commit 21742ff
Show file tree
Hide file tree
Showing 4 changed files with 44 additions and 2 deletions.
19 changes: 19 additions & 0 deletions doc/source/parameters.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1251,6 +1251,19 @@ root_volume:
in: body
required: false
type: boolean
update_connections_only:
description: |
Update connections in database only, do not undedicate in CP.
in: body
required: false
type: boolean
do_rollback:
description: |
Roll back will be done if any phase fails.
Default is True.
in: body
required: false
type: boolean
disk_list_output:
description: |
A list of created disks information for the guest.
Expand Down Expand Up @@ -1342,6 +1355,12 @@ fcp_list:
in: body
required: true
type: list
fcp_template_id:
description: |
Unique identifier of the FCP template.
in: body
required: true
type: string
wwpn_list:
description: |
World Wide Port Name identifiers.
Expand Down
8 changes: 6 additions & 2 deletions doc/source/restapi.rst
Original file line number Diff line number Diff line change
Expand Up @@ -381,16 +381,18 @@ Attach a volume to a VM in z/VM.
- connection: volume_conn
- assigner_id: assigner_id
- zvm_fcp: fcp_list
- fcp_template_id: fcp_template_id
- target_wwpn: volume_wwpn
- target_lun: volume_lun
- os_version: guest_os_version
- multipath: guest_multipath
- mount_point: mount_point
- is_root_volume: root_volume
- do_rollback: do_rollback

* Request sample:

.. literalinclude:: ../../zvmsdk/tests/fvt/api_templates/test_volume_attach_detach.tpl
.. literalinclude:: ../../zvmsdk/tests/fvt/api_templates/test_volume_attach.tpl
:language: javascript

* Response code:
Expand Down Expand Up @@ -422,10 +424,12 @@ Detach a volume from a VM in z/VM.
- multipath: guest_multipath
- mount_point: mount_point
- is_root_volume: root_volume
- update_connections_only: update_connections_only
- do_rollback: do_rollback

* Request sample:

.. literalinclude:: ../../zvmsdk/tests/fvt/api_templates/test_volume_attach_detach.tpl
.. literalinclude:: ../../zvmsdk/tests/fvt/api_templates/test_volume_detach.tpl
:language: javascript

* Response code:
Expand Down
18 changes: 18 additions & 0 deletions zvmsdk/tests/fvt/api_templates/test_volume_attach.tpl
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"info":
{
"connection":
{
"assigner_id": "username",
"zvm_fcp": "1fc5",
"fcp_template_id": "307c88c6-a5e0-11ef-b1eb-5b75c5890e27",
"target_wwpn": "0x50050763050b073d",
"target_lun": "0x4020400100000000",
"os_version": "redhat7",
"multipath": True,
"mount_point": "/dev/sdz",
"is_root_volume": False,
"do_rollback": True
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"multipath": True,
"mount_point": "/dev/sdz",
"is_root_volume": False,
"update_connections_only": False,
"do_rollback": True
}
}
Expand Down

0 comments on commit 21742ff

Please sign in to comment.