New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type replace regex #67

Merged

ahocevar merged 2 commits into openlayers:main from Daniel-Knights:fix-type-replace-regex

Oct 16, 2024

Contributor

Daniel-Knights commented Oct 16, 2024 •

edited

Loading

If a key in identifiers matches the name of a module:, event:, or external: namepath, it'll end up being prefixed with module:.

So @returns {module:geometry} becomes @returns {module:module:geometry}, if a geometry identifier exists elsewhere.

This PR updates the regex to exclude these cases.

Daniel-Knights added 2 commits

October 16, 2024 13:58


          Fix type replace regex to exclude already formatted namepaths

90636aa


          Remove unnecessary http exclusion in type replace regex

a0e2d61

ahocevar approved these changes

View reviewed changes

ahocevar merged commit 2ccc16d into openlayers:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet