Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unsupported extension #504

Closed
wants to merge 1 commit into from
Closed

Conversation

HankBO
Copy link
Contributor

@HankBO HankBO commented Oct 22, 2024

Description (e.g. "Related to ...", etc.)

Request removing the extension in Implementations.md for sake of no longer supported.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

Automated linters

You can run the lints that are run on CI locally with:

poetry install --all-extras --with dev
poetry run poe lint

@tombh
Copy link
Collaborator

tombh commented Oct 22, 2024

That's a shame, but thanks for letting us know. Would you like to change the commit message to docs: remove Stata server? Or I can do it if you like.

@HankBO
Copy link
Contributor Author

HankBO commented Oct 22, 2024

Yes, please

@tombh
Copy link
Collaborator

tombh commented Oct 22, 2024

Done, merged in #505

@tombh tombh closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants