Update GOVERNANCE.md regarding merging PRs rule #1314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
WaleedAshraf
commented
Jun 3, 2024
WaleedAshraf
commented
- Clarify that the rules apply to all the repos under OpenJS Foundation org
Clarify that the rules apply to all the repo's under OpenJS Foundation org Signed-off-by: Waleed Ashraf <[email protected]>
|
Closing this PR. My initial thought was that we follow these PR rules in all the repos, but that's not the case. For example, in the Summit repo, we merge changes directly, sometimes even directly push to main for typos. |
|
Indeed, these rules only apply to this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.