#107 Update samples with latest versions #33
Conversation
| @@ -22,28 +22,28 @@ | |||
| <dependency> | |||
| <groupId>org.openjfx</groupId> | |||
| <artifactId>javafx-controls</artifactId> | |||
| <version>12.0.1</version> | |||
| <version>12.0.2</version> | |||
There was a problem hiding this comment.
Use a maven property for this to make future changes easier.
There was a problem hiding this comment.
Even if we use Maven properties, these will be on top of each pom, so we will have to update every single file either way.
We could add a parent pom for all the maven samples, but I don't think we should, as each sample is isolated.
There was a problem hiding this comment.
Sure. However, in this case we update it at one place instead of spreading it across the file.
There was a problem hiding this comment.
But this applies only if we have two or more dependencies, so it is a little bit overkilling imo
| </dependency> | ||
| </dependencies> | ||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.8.0</version> | ||
| <version>3.8.1</version> |
There was a problem hiding this comment.
This may also move to a maven property to keep all versions consolidated at one place.
| <classifier>linux</classifier> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.openjfx</groupId> | ||
| <artifactId>javafx-graphics</artifactId> | ||
| <version>12.0.1</version> | ||
| <version>12.0.2</version> |
There was a problem hiding this comment.
As stated before, these versions can move to maven properties to make future changes easier.
| .button { | ||
| -fx-font-weight: bold; | ||
| .label { | ||
| -fx-text-fill: blue; | ||
| } |
There was a problem hiding this comment.
We should remember to close PR #30 after we merge this PR.
No description provided.