7904015: --verify-exclude fails to abort the test run when discovering failures

[LudwikJaniuk]

Exit after discovering errors in exclude files

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• CODETOOLS-7904015: --verify-exclude fails to abort the test run when discovering failures (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/265/head:pull/265
$ git checkout pull/265

Update a local copy of the PR:
$ git checkout pull/265
$ git pull https://git.openjdk.org/jtreg.git pull/265/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 265

View PR using the GUI difftool:
$ git pr show -t 265

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/265.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lujaniuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[mlbridge]

Webrevs

• 01: Full - Incremental (9095c8e1)
• 00: Full (4fa2e071)

[jaikiran]

Hello Ludvig, this looks reasonable to me, but I think we should have a self test for this to verify that it indeed exits with a non-zero exit code in situations like these.

[sormuras]

Hello Ludvig, this looks reasonable to me, but I think we should have a self test for this to verify that it indeed exits with a non-zero exit code in situations like these.

Maybe the logic in VerifyExcludeTest.gmk can be extend to check the exit code?

[jaikiran]

Maybe the logic in VerifyExcludeTest.gmk can be extend to check the exit code?

Yes, that should be fine.

[LudwikJaniuk]

Thank you for the suggestion, I have added the self test. Testing the exit code itself was cumbersome, as the return code also varies with test results. I opted to check for the "test results" string instead, hope this is okay.