Skip to content

8354875: Update to GCC 14.2.0 on Linux #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 17, 2025

This PR updates the compiler on Linux to GCC 14.2.0 (from 13.2.0) to match JDK 25.

I ran a full headless and headful test run, including building media and WebKit, on the following:

  • Oracle Linux 8 (our production build and headless test platform)
  • Ubuntu 16.04
  • Ubuntu 22.04
  • Ubuntu 24.04

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8354875: Update to GCC 14.2.0 on Linux (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1784/head:pull/1784
$ git checkout pull/1784

Update a local copy of the PR:
$ git checkout pull/1784
$ git pull https://git.openjdk.org/jfx.git pull/1784/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1784

View PR using the GUI difftool:
$ git pr show -t 1784

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1784.diff

Using Webrev

Link to Webrev Comment

@kevinrushforth kevinrushforth changed the title 8354875 gcc 14.2 8354875: Update to GCC 14.2.0 on Linux Apr 17, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 17, 2025

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354875: Update to GCC 14.2.0 on Linux

Reviewed-by: sykora, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 498b7e4: 8176813: Mac: Failure to exit full-screen programmatically in some cases
  • 096765a: 8353314: macOS: Inconsistent fullscreen behavior

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@kevinrushforth
Copy link
Member Author

Reviewers: @arapte @tiainen

/reviewers 2

@kevinrushforth kevinrushforth marked this pull request as ready for review April 25, 2025 21:52
@openjdk
Copy link

openjdk bot commented Apr 25, 2025

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@openjdk openjdk bot added the rfr Ready for review label Apr 25, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 25, 2025

Webrevs

Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated our build infrastructure with gcc 14.2.0 and build and tests all ran fine.

Copy link
Member

@arapte arapte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Ready to be integrated label May 6, 2025
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 6, 2025

Going to push as commit efaff94.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 498b7e4: 8176813: Mac: Failure to exit full-screen programmatically in some cases
  • 096765a: 8353314: macOS: Inconsistent fullscreen behavior

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 6, 2025
@openjdk openjdk bot closed this May 6, 2025
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels May 6, 2025
@openjdk
Copy link

openjdk bot commented May 6, 2025

@kevinrushforth Pushed as commit efaff94.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8354875-gcc-14.2 branch May 6, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants