8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java

[kurashige23]

Hi all,

This is a backport of JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java

Original patch doesn't apply cleanly to 8u because JDK-8056911 isn't backported to 8u.

Backporting JDK-8056911 involves changing the behavior of a public method so it is risky. In addition to that, it does not lead to significant bug fix. For these reasons, I do not think it is appropriate to apply JDK-8056911 as a dependent fix.
So I made a slightly different fix from the original patch. Specifically, I modified to use an ExtendedRobot instead of Robot.

Testing: java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java on RHEL9.2

Thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8160767 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/637/head:pull/637
$ git checkout pull/637

Update a local copy of the PR:
$ git checkout pull/637
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/637/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 637

View PR using the GUI difftool:
$ git pr show -t 637

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/637.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kurashige23! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (34784cea)
• 00: Full (f5c72762)

[kurashige23]

This is a clean backport as only path changes.

/clean

[openjdk]

@kurashige23 The /clean pull request command is not enabled for this repository

[mrserb]

I'm not sure this will be enough for jdk8. https://bugs.openjdk.org/browse/JDK-8056911 was not ported to jdk8, so Robot.waitForIdle() uses a "dummy" implementation.

[kurashige23]

Sorry, I wasn't aware that Robot.waitForIdle() uses a dummy implementation.
I thought it was necessary to apply JDK-8056911 first, but backporting JDK-8056911 has been rejected in the past because changing the behavior of public methods is undesirable.
I will consider whether I should backport JDK-8056911. If the JDK-8056911 backport is not appropriate, I will implement another fix in this PR.

[kurashige23]

I think that backporting JDK-8056911 is not consistent with consequences described in section "What form should back-ported patches take?" at Best practices for OpenJDK 8 updates . This is because backporting JDK-8056911 does not result in any significant bug fixes.
Therefore, I modified the test to use ExtendedRobot instead of Robot.

[kurashige23]

@mrserb

If you have time, I would like you to check my comment. Thanks.

[bridgekeeper]

@kurashige23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!