Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8160974: [TESTBUG] Mark more headful tests with @key headful. #607

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yaqsun
Copy link
Contributor

@yaqsun yaqsun commented Nov 19, 2024

This backport has modified the following aspects:

  • there are 56 cases that do not exist:
    jdk/test/com/sun/java/accessibility/util/8051626/Bug8051626.java
    jdk/test/java/awt/Component/GetScreenLocTest/GetScreenLocTest.java
    jdk/test/java/awt/Dialog/ChildProperties/ChildDialogProperties.java
    jdk/test/java/awt/LightweightComponent/LightweightEventTest/LightweightEventTest.java
    jdk/test/java/awt/PrintJob/PrinterException.java
    jdk/test/java/awt/TextField/TextFieldEditing/TextFieldEditing.java
    jdk/test/java/awt/Window/ChildProperties/ChildWindowProperties.java
    jdk/test/java/awt/datatransfer/UnicodeTransferTest/UnicodeTransferTest.java
    jdk/test/java/awt/image/multiresolution/MenuMultiresolutionIconTest.java
    jdk/test/java/awt/image/multiresolution/MultiResolutionJOptionPaneIconTest.java
    jdk/test/java/awt/print/PrintJob/PrinterException.java
    jdk/test/javax/swing/Action/8133039/bug8133039.java
    jdk/test/javax/swing/GroupLayout/8013566/bug8013566.java
    jdk/test/javax/swing/GroupLayout/8079640/bug8079640.java
    jdk/test/javax/swing/InputVerifier/VerifyTarget/VerifyTargetTest.java
    jdk/test/javax/swing/JButton/PressedButtonRightClickTest.java
    jdk/test/javax/swing/JColorChooser/Test8051548.java
    jdk/test/javax/swing/JDialog/Transparency/TransparencyTest.java
    jdk/test/javax/swing/JEditorPane/8146319/JEditorPaneTest.java
    jdk/test/javax/swing/JFileChooser/8016665/JFileChooserOrientation.java
    jdk/test/javax/swing/JFileChooser/8041694/bug8041694.java
    jdk/test/javax/swing/JFileChooser/DeserializedJFileChooser/DeserializedJFileChooserTest.java
    jdk/test/javax/swing/JInternalFrame/4769772/TestJInternalFrameIconify.java
    jdk/test/javax/swing/JInternalFrame/8069348/bug8069348.java
    jdk/test/javax/swing/JInternalFrame/8145896/TestJInternalFrameMaximize.java
    jdk/test/javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java
    jdk/test/javax/swing/JInternalFrame/NormalBoundsTest.java
    jdk/test/javax/swing/JMenu/4213634/bug4213634.java
    jdk/test/javax/swing/JOptionPane/8139213/OptionPaneTest.java
    jdk/test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java
    jdk/test/javax/swing/JProgressBar/8015748/JProgressBarOrientationRobotTest.java
    jdk/test/javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java
    jdk/test/javax/swing/JRootPane/SilenceOfDeprecatedMenuBar/SilenceOfDeprecatedMenuBar.java
    jdk/test/javax/swing/JScrollPane/bug8044371.java
    jdk/test/javax/swing/JSpinner/6421058/bug6421058.java
    jdk/test/javax/swing/JSpinner/WrongEditorTextFieldFont/WrongEditorTextFieldFont.java
    jdk/test/javax/swing/JTabbedPane/8017284/bug8017284.java
    jdk/test/javax/swing/JTabbedPane/8134116/Bug8134116.java
    jdk/test/javax/swing/JTabbedPane/8137169/ScrollableTabbedPaneTest.java
    jdk/test/javax/swing/JTable/6894632/bug6894632.java
    jdk/test/javax/swing/JTableHeader/4473075/bug4473075.java
    jdk/test/javax/swing/JTextArea/8149849/DNDTextToScaledArea.java
    jdk/test/javax/swing/JTextPane/bug8025082.java
    jdk/test/javax/swing/JToolTip/6219960/bug6219960.java
    jdk/test/javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java
    jdk/test/javax/swing/LookAndFeel/6897701/JMenuItemsTest.java
    jdk/test/javax/swing/LookAndFeel/8146276/NimbusGlueTest.java
    jdk/test/javax/swing/plaf/basic/BasicComboPopup/7072653/bug7072653.java
    jdk/test/javax/swing/plaf/basic/BasicRootPaneUI/HiddenDefaultButtonTest.java
    jdk/test/javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java
    jdk/test/javax/swing/plaf/synth/8040328/bug8040328.java
    jdk/test/javax/swing/plaf/synth/SynthScrollbarThumbPainter/SynthScrollbarThumbPainterTest.java
    jdk/test/javax/swing/text/NavigationFilter/8058305/bug8058305.java
    jdk/test/javax/swing/text/TableView/I18nLayoutTest.java
    jdk/test/javax/swing/text/html/8031109/bug8031109.java
    jdk/test/javax/swing/text/rtf/RTFWriteParagraphAlignTest.java
  • The following two cases have been added @key headful
    jdk/test/java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java
    jdk/test/javax/swing/ToolTipManager/7123767/bug7123767.java
  • context is adapted where needed

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8160974 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8160974: [TESTBUG] Mark more headful tests with @key headful. (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/607/head:pull/607
$ git checkout pull/607

Update a local copy of the PR:
$ git checkout pull/607
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/607/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 607

View PR using the GUI difftool:
$ git pr show -t 607

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/607.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2024

👋 Welcome back yaqsun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 19, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 8160974: [TESTBUG] Mark more headful tests with @key headful. Nov 19, 2024
@openjdk
Copy link

openjdk bot commented Nov 19, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport approval rfr Pull request is ready for review labels Nov 19, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 19, 2024

Webrevs

@gnu-andrew
Copy link
Member

This seems to be a dupe of #383?

@yaqsun
Copy link
Contributor Author

yaqsun commented Dec 5, 2024

This seems to be a dupe of #383?

Yes, it is.
And the difference in quantity between #607 and #383 is that I did not handle jdk/test/java/awt/Focus/MouseClickRequestFocusRaceTest/MouseClickRequestFocusRaceTest.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants