Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287113: JFR: Periodic task thread uses period for method sampling events #601

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented Nov 6, 2024

Clean backport from JDK11
I'd like to backport it to improve resource usage when running an application with the JFR default profile.

All JFR-related JTREG tests passed


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8287113 needs maintainer approval

Issue

  • JDK-8287113: JFR: Periodic task thread uses period for method sampling events (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/601/head:pull/601
$ git checkout pull/601

Update a local copy of the PR:
$ git checkout pull/601
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/601/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 601

View PR using the GUI difftool:
$ git pr show -t 601

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/601.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2024

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 6, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 8122466fbb8e3f3450131895551ec5b832845938 8287113: JFR: Periodic task thread uses period for method sampling events Nov 6, 2024
@openjdk
Copy link

openjdk bot commented Nov 6, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 6, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 6, 2024

Webrevs

@alexeybakhtin
Copy link
Contributor Author

alexeybakhtin commented Nov 6, 2024

Test failures not related to the changes in this PR

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Nov 20, 2024
@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 20, 2024
@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Nov 20, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 20, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2024

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant