Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java #567

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Aug 26, 2024

Hi all,
This PR contains two backports JDK-8266881 and JDK-8227651 from jdk11u-dev.
We observed javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch by ours nightly CI, so we want to backport these two PRs to fix the test bugs which cause intermittent fails.

The change in test/jdk/ProblemList.txt was not needed deal with in jdk8u-dev, all other files are backported cleanly.

Changes(total 6 releated testcases) has been verified locally. Test fix only, no risk.

Additional testing:

  • full jtreg tests on linux x64
  • full jtreg tests on linux aarch64

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8266881 needs maintainer approval
  • JDK-8212096 needs maintainer approval
  • JDK-8227651 needs maintainer approval

Issues

  • JDK-8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java (Bug - P4 - Requested)
  • JDK-8212096: javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch (Bug - P3 - Requested)
  • JDK-8227651: Tests fail with SSLProtocolException: Input record too big (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/567/head:pull/567
$ git checkout pull/567

Update a local copy of the PR:
$ git checkout pull/567
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/567/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 567

View PR using the GUI difftool:
$ git pr show -t 567

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/567.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 26, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 8138382780b16f4184ad5bbfe07ab2468afe71a8 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java Aug 26, 2024
@openjdk
Copy link

openjdk bot commented Aug 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 26, 2024
@sendaoYan
Copy link
Member Author

/issue JDK-8266881

@sendaoYan
Copy link
Member Author

/issue JDK-8212096

@openjdk
Copy link

openjdk bot commented Aug 26, 2024

@sendaoYan This issue is referenced in the PR title - it will now be updated.

@sendaoYan
Copy link
Member Author

/issue JDK-8227651

@openjdk
Copy link

openjdk bot commented Aug 26, 2024

@sendaoYan
Adding additional issue to issue list: 8212096: javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch.

@openjdk
Copy link

openjdk bot commented Aug 26, 2024

@sendaoYan
Adding additional issue to issue list: 8227651: Tests fail with SSLProtocolException: Input record too big.

@mlbridge
Copy link

mlbridge bot commented Aug 26, 2024

Webrevs

@sendaoYan
Copy link
Member Author

Changes(total 6 releated testcases) has been verified locally.
test.log

@sendaoYan
Copy link
Member Author

sendaoYan commented Aug 26, 2024

/approval JDK-8266881 request Prefixed backport of JDK-8212096, add debug information, test-fix only, no risk.

@sendaoYan
Copy link
Member Author

@openjdk
Copy link

openjdk bot commented Aug 26, 2024

@sendaoYan
JDK-8266881: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Aug 26, 2024
@sendaoYan
Copy link
Member Author

/approval JDK-8212096 request Backport from jdk11u-dev to jdk8u-dev, to fix the intermittent failure, test fix only, the change has been verified, no risk.

@sendaoYan
Copy link
Member Author

/approval JDK-8227651 request Backport from jdk11u-dev to jdk8u-dev, to fix the intermittent failure, test fix only, the change has been verified, no risk.

@openjdk
Copy link

openjdk bot commented Aug 26, 2024

@sendaoYan
JDK-8212096: The approval request has been created successfully.

@openjdk
Copy link

openjdk bot commented Aug 26, 2024

@sendaoYan
JDK-8227651: The approval request has been created successfully.

@sendaoYan
Copy link
Member Author

Thanks for the review.

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/open

@openjdk
Copy link

openjdk bot commented Sep 24, 2024

@sendaoYan This pull request is already open

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/open

@openjdk
Copy link

openjdk bot commented Oct 22, 2024

@sendaoYan This pull request is already open

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/approval JDK-8266881 request Prefixed backport of JDK-8212096, add debug information, test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Nov 20, 2024

@sendaoYan
JDK-8266881: The approval request was already up to date.

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants