-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java #567
base: master
Are you sure you want to change the base?
Conversation
Backport-of: 266702451db57c4f006f22601288174cc0613339
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
/issue JDK-8266881 |
/issue JDK-8212096 |
@sendaoYan This issue is referenced in the PR title - it will now be updated. |
/issue JDK-8227651 |
@sendaoYan |
@sendaoYan |
Changes(total 6 releated testcases) has been verified locally. |
/approval JDK-8266881 request Prefixed backport of JDK-8212096, add debug information, test-fix only, no risk. |
All the GHA test failures are unreleated to this PR
|
@sendaoYan |
/approval JDK-8212096 request Backport from jdk11u-dev to jdk8u-dev, to fix the intermittent failure, test fix only, the change has been verified, no risk. |
/approval JDK-8227651 request Backport from jdk11u-dev to jdk8u-dev, to fix the intermittent failure, test fix only, the change has been verified, no risk. |
@sendaoYan |
@sendaoYan |
Thanks for the review. |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/open |
@sendaoYan This pull request is already open |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/open |
@sendaoYan This pull request is already open |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/approval JDK-8266881 request Prefixed backport of JDK-8212096, add debug information, test-fix only, no risk. |
@sendaoYan |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi all,
This PR contains two backports JDK-8266881 and JDK-8227651 from jdk11u-dev.
We observed
javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch
by ours nightly CI, so we want to backport these two PRs to fix the test bugs which cause intermittent fails.The change in
test/jdk/ProblemList.txt
was not needed deal with in jdk8u-dev, all other files are backported cleanly.Changes(total 6 releated testcases) has been verified locally. Test fix only, no risk.
Additional testing:
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/567/head:pull/567
$ git checkout pull/567
Update a local copy of the PR:
$ git checkout pull/567
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/567/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 567
View PR using the GUI difftool:
$ git pr show -t 567
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/567.diff
Using Webrev
Link to Webrev Comment