Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo #504

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo #504

wants to merge 2 commits into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented May 23, 2024 •
edited by openjdk bot
Loading

Hi all,
This is backport of JDK-8048215. This PR try to fixed the intermitent failure. The change has been verifed. Only change the testcase, no risk.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8048215 needs maintainer approval

Issue

  • JDK-8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/504/head:pull/504
$ git checkout pull/504

Update a local copy of the PR:
$ git checkout pull/504
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/504/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 504

View PR using the GUI difftool:
$ git pr show -t 504

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/504.diff

Using Webrev

Link to Webrev Comment

@sendaoYan
8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBea…
fba26ac 
…nProxy.java Expected non-null LockInfo

Ensure the target thread has reached wait() before inspecting it

Reviewed-by: mchung, dfuchs, jcbeyler
@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 23, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 84b88b391288bb4297bc941d9047a0cfaa5c60b2 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo May 23, 2024
@openjdk
Copy link

openjdk bot commented May 23, 2024

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 23, 2024
@sendaoYan
Copy link
Member Author

sendaoYan commented May 23, 2024 •
edited
Loading

/approval request Backport which try to fixed the intermitent failure. The change has been verifed. Only change the testcase, no risk.

@openjdk
Copy link

openjdk bot commented May 23, 2024

@sendaoYan
8048215: The approval request has been created successfully.

@openjdk openjdk bot added the approval label May 23, 2024
@mlbridge
Copy link

mlbridge bot commented May 23, 2024 •
edited
Loading

Webrevs

@sendaoYan
Copy link
Member Author

The GHA test runner report 4 failures. All the failures seems environmental issue, unreleated to this PR.

@sendaoYan
Copy link
Member Author

sendaoYan commented May 24, 2024 •
edited
Loading

The GHA report failure CAInterop.java#digicerttlsrsarootg5 and CAInterop.java#quovadisrootca1g3, which has been record in JDK-8324583, unrelated to this PR.
The GHA report failure gc/6581734/Test6581734.java, I have created a new issue JDK-8332853 to record this failure. It's unrelated to this PR.

Other failures reported by GHA seems to environmental issues, unrelated to this PR.

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 21, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

Hi all, can anyone take a review to this PR.

@sendaoYan
Copy link
Member Author

The GHA test runner report 3 failures:

  1. com/sun/jdi/JdbExprTest.sh, unrelated to this PR. I has created a issue to record ths failure.
  2. security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrootrsaca fails, unrelated to this PR, which is fixing.
  3. security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrootevrsaca fails, unrelated to this PR, which is fixing.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 19, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/open

@openjdk
Copy link

openjdk bot commented Jul 20, 2024

@sendaoYan This pull request is already open

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 17, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

Hi, can anyone task look this PR.

@phohensee
Copy link
Member

GHA failures are unrelated.

@sendaoYan
Copy link
Member Author

Thanks for the review.

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 17, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/approval request Backport to fixed the intermitent failure. The change has been verifed. Only change the testcase, no risk.

@openjdk
Copy link

openjdk bot commented Sep 17, 2024

@sendaoYan
8048215: The approval request has been updated successfully.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 15, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/open

@openjdk
Copy link

openjdk bot commented Oct 15, 2024

@sendaoYan This pull request is already open

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/open

@openjdk
Copy link

openjdk bot commented Nov 12, 2024

@sendaoYan This pull request is already open

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 10, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/open

@openjdk
Copy link

openjdk bot commented Dec 11, 2024

@sendaoYan This pull request is already open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phohensee phohensee phohensee approved these changes

Assignees
No one assigned
Labels
approval backport rfr Pull request is ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sendaoYan @phohensee