Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8048892: TEST_BUG: shell script tests need to be change to not use retired @debuggeeVMOptions mechanism #493

Open
wants to merge 1 commit into
base: pr/492
Choose a base branch
from

Conversation

ktakakuri
Copy link
Contributor

@ktakakuri ktakakuri commented May 7, 2024

Hi all,

I would like to backport this patch to improve test maintainability.
This patch icompliments JDK-6622468, which I have already proposed for backporting. #492
The patch is clean. However there is a typo in this patch, which was later fixed as part of JDK-8143583. Without modification, the added test fails. JDK-8143583 contains fixes for other tessts which were not backported, and I think backporting it for this patch is not reasonable. Given this, I also corrected a typo in tis patch.

Testing: All tests under jdk/test/com/sun/jdi

Thank you.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8048892 needs maintainer approval

Integration blocker

 ⚠️ Dependency #492 must be integrated first

Issue

  • JDK-8048892: TEST_BUG: shell script tests need to be change to not use retired @debuggeeVMOptions mechanism (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/493/head:pull/493
$ git checkout pull/493

Update a local copy of the PR:
$ git checkout pull/493
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/493/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 493

View PR using the GUI difftool:
$ git pr show -t 493

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/493.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 7, 2024

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into pr/492 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 7, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport f377795d11a5d67f9617ae6551bffd16398e1efd 8048892: TEST_BUG: shell script tests need to be change to not use retired @debuggeeVMOptions mechanism May 7, 2024
@openjdk
Copy link

openjdk bot commented May 7, 2024

This backport pull request has now been updated with issue from the original commit.

@mlbridge
Copy link

mlbridge bot commented May 7, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 4, 2024

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 3, 2024

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jul 3, 2024
@ktakakuri
Copy link
Contributor Author

/open

@openjdk
Copy link

openjdk bot commented Jul 3, 2024

@ktakakuri The target branch of this pull request no longer exists. Please retarget this pull request. Please issue this command again once the problem has been resolved.

@ktakakuri
Copy link
Contributor Author

/open

@openjdk openjdk bot reopened this Jul 3, 2024
@openjdk
Copy link

openjdk bot commented Jul 3, 2024

@ktakakuri This pull request is now open

@ktakakuri
Copy link
Contributor Author

Could someone please review this backport along with #492?

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 31, 2024

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 28, 2024

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Aug 28, 2024
@ktakakuri
Copy link
Contributor Author

ktakakuri commented Aug 29, 2024

/open

@openjdk
Copy link

openjdk bot commented Aug 29, 2024

@ktakakuri The target branch of this pull request no longer exists. Please retarget this pull request. Please issue this command again once the problem has been resolved.

@ktakakuri
Copy link
Contributor Author

/open

@openjdk openjdk bot reopened this Aug 29, 2024
@openjdk
Copy link

openjdk bot commented Aug 29, 2024

@ktakakuri This pull request is now open

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 26, 2024

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@ktakakuri
Copy link
Contributor Author

Could someone please review this backport along with #492?

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 29, 2024

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@ktakakuri
Copy link
Contributor Author

Could someone please review this backport along with #492?

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2024

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@ktakakuri
Copy link
Contributor Author

Could someone please review this backport along with #492?

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 26, 2024

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@ktakakuri
Copy link
Contributor Author

Could someone please review this backport along with #492?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant