Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8324587: @headful key is contained in ExceptionFromPrintableIsIgnoredTest.java #425

Closed
wants to merge 1 commit into from

Conversation

ktakakuri
Copy link
Contributor

@ktakakuri ktakakuri commented Jan 24, 2024

This fix removes the "@key headful printer" tag that was granted to ExceptionFromPrintableIsIgnoredTest.java in JDK-8273687. The test passed after this fix.
Would you review this fix, please?


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8324587 needs maintainer approval

Issue

  • JDK-8324587: @headful key is contained in ExceptionFromPrintableIsIgnoredTest.java (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/425/head:pull/425
$ git checkout pull/425

Update a local copy of the PR:
$ git checkout pull/425
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/425/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 425

View PR using the GUI difftool:
$ git pr show -t 425

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/425.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 24, 2024

👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 24, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 24, 2024

Webrevs

@mrserb
Copy link
Member

mrserb commented Jan 25, 2024

How hard it will be backport the JDK-8185500?

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 22, 2024

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 11, 2024

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@ktakakuri
Copy link
Contributor Author

It appears that a pull request has already been issued for JDK-8185500. #464
I will close my pull request once it is merged.

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2024

@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2024

@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jun 7, 2024
@ktakakuri
Copy link
Contributor Author

If there is a problem with #464 I will reopen this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants