-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8324587: @headful key is contained in ExceptionFromPrintableIsIgnoredTest.java #425
Conversation
👋 Welcome back ktakakuri! A progress list of the required criteria for merging this PR into |
How hard it will be backport the JDK-8185500? |
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
❗ This change is not yet ready to be integrated. |
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
It appears that a pull request has already been issued for JDK-8185500. #464 |
@ktakakuri This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@ktakakuri This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
If there is a problem with #464 I will reopen this pull request. |
This fix removes the "@key headful printer" tag that was granted to ExceptionFromPrintableIsIgnoredTest.java in JDK-8273687. The test passed after this fix.
Would you review this fix, please?
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/425/head:pull/425
$ git checkout pull/425
Update a local copy of the PR:
$ git checkout pull/425
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/425/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 425
View PR using the GUI difftool:
$ git pr show -t 425
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/425.diff
Webrev
Link to Webrev Comment