Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8342578: GHA: RISC-V: Bootstrap using Debian snapshot is still failing #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RealFYang
Copy link
Member

@RealFYang RealFYang commented Oct 31, 2024

Hi all,

This pull request contains a backport of commit 239d84a8 from the openjdk/jdk repository.

The commit being backported was authored by Fei Yang on 21 Oct 2024 and was reviewed by Aleksey Shipilev and Erik Joelsson.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8342578 needs maintainer approval

Issue

  • JDK-8342578: GHA: RISC-V: Bootstrap using Debian snapshot is still failing (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/212/head:pull/212
$ git checkout pull/212

Update a local copy of the PR:
$ git checkout pull/212
$ git pull https://git.openjdk.org/jdk23u.git pull/212/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 212

View PR using the GUI difftool:
$ git pr show -t 212

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/212.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2024

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 31, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 239d84a82a1e6f4ebbd5c5abb320e39cfd5bc330 8342578: GHA: RISC-V: Bootstrap using Debian snapshot is still failing Oct 31, 2024
@openjdk
Copy link

openjdk bot commented Oct 31, 2024

This backport pull request has now been updated with issue from the original commit.

@RealFYang
Copy link
Member Author

/approval request Clean backport of JDK-8342578 to fix GHA linux-cross-build for riscv64 job. Backport risk should be low as this is a small GHA fix.

@RealFYang RealFYang marked this pull request as ready for review October 31, 2024 04:01
@openjdk
Copy link

openjdk bot commented Oct 31, 2024

@RealFYang
8342578: The approval request has been created successfully.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Oct 31, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 31, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2024

@RealFYang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@RealFYang
Copy link
Member Author

bot, please keep it open.

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 26, 2024

@RealFYang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@RealFYang
Copy link
Member Author

keep alive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant