Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322983: Virtual Threads: exclude 2 tests #1285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Dec 23, 2024

Hi all,

This pull request contains a backport of commit cf28fd4c from the openjdk/jdk repository.

The commit being backported was authored by Evgeny Nikitin on 20 Dec 2024 and was reviewed by Jaikiran Pai, Leonid Mesnik and SendaoYan.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8322983 needs maintainer approval

Issue

  • JDK-8322983: Virtual Threads: exclude 2 tests (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1285/head:pull/1285
$ git checkout pull/1285

Update a local copy of the PR:
$ git checkout pull/1285
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1285/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1285

View PR using the GUI difftool:
$ git pr show -t 1285

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1285.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport cf28fd4cbc6507eb69fcfeb33622316eb5b6b0c5 8322983: Virtual Threads: exclude 2 tests Dec 23, 2024
@openjdk
Copy link

openjdk bot commented Dec 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 23, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport to Problemlist 2 tests which can not run with TEST_THREAD_FACTORY=Virtual. No risk.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@sendaoYan
8322983: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant