8345173: BlockLocationPrinter::print_location misses a ResourceMark

[satyenme]

Backporting JDK-8345173: BlockLocationPrinter::print_location misses a ResourceMark. Since BlockLocationPrinter can be called at any point (e.g. the stop() method of MacroAssembler), it may currently fail with a "Missing ResourceMark error - possible memory leak" error instead of providing the stop() output (and then failing). Ran GHA Sanity Checks and local Tier 1 and 2. Patch is clean.

---

Progress

• Change must not contain extraneous whitespace
• JDK-8345173 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8345173: BlockLocationPrinter::print_location misses a ResourceMark (Bug - P5 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3665/head:pull/3665
$ git checkout pull/3665

Update a local copy of the PR:
$ git checkout pull/3665
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3665/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3665

View PR using the GUI difftool:
$ git pr show -t 3665

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3665.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (20e32bb0)

[satyenme]

/approval request for backport of JDK-8345173: BlockLocationPrinter::print_location misses a ResourceMark

Motivation: Without this change BlockLocationPrinter::print_location can be called at very arbitrary places (e.g. the stop() method of MacroAssembler), and without this change it might fail with a "Missing ResourceMark error - possible memory leak" error instead of providing the stop() output (and then failing). With this change, the ResourceMark should no longer have a possibility of crashing in this way.

Risk: Low. Ran GHA Sanity Checks, and local Tier 1 and 2 tests directly. Patch is clean. Change has been present in tip since December, 2024.

[openjdk]

@satyenme
8345173: The approval request has been created successfully.