Skip to content

8339725: Concurrent GC crashed due to GetMethodDeclaringClass #3646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fandreuz
Copy link
Contributor

@fandreuz fandreuz commented Jun 16, 2025

Backport JDK-8339725. Applies almost cleanly. Fixes a crash in concurrent GC due to GetMethodDeclaringClass.

I ran the reproducer against jdk17, and I confirm that the crash applies to this version too.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8339725 needs maintainer approval

Issue

  • JDK-8339725: Concurrent GC crashed due to GetMethodDeclaringClass (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3646/head:pull/3646
$ git checkout pull/3646

Update a local copy of the PR:
$ git checkout pull/3646
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3646/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3646

View PR using the GUI difftool:
$ git pr show -t 3646

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3646.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2025

👋 Welcome back fandreuz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport c91fa278fe17ab204beef0fcef1ada6dd0bc37bb 8339725: Concurrent GC crashed due to GetMethodDeclaringClass Jun 16, 2025
@openjdk
Copy link

openjdk bot commented Jun 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 16, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 16, 2025

⚠️ @fandreuz This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@fandreuz
Copy link
Contributor Author

/approval request Fixes JDK-8339725. Solves a crash during concurrent GC after a call to GetMethodDeclaringClass.

@openjdk
Copy link

openjdk bot commented Jun 16, 2025

@fandreuz
8339725: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jun 16, 2025
@GoeLin
Copy link
Member

GoeLin commented Jun 18, 2025

Hi @fandreuz
Please be a bit more elaborate in your fix-request comment. See also
https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix

@fandreuz
Copy link
Contributor Author

/approval request Fixes JDK-8339725. Applies almost cleanly, except for small changes required in test makefiles. Passes tier 1 test suite. This backport solves a crash in concurrent GC after a call to GetMethodDeclaringClass. I confirm that the newly introduced test fails on master and is fixed with this backport.

@fandreuz
Copy link
Contributor Author

Hi @GoeLin, thank you for the feedback. I amended my approval request

@openjdk
Copy link

openjdk bot commented Jun 18, 2025

@fandreuz
8339725: The approval request has been updated successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants