8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x #3150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A mostly clean backport of JDK-8294316 to properly parse core files in macOS 12 and later. Load commands with length zero are now discarded.
The fix doesn't affect directly to SA tests in 17, but it's being backported to 11 as this is the cause of openjdk/jdk11u-dev#2967 (comment).
Tests in 17 continue to pass in all platforms, including macos.
The change is not clean as there were merge conflicts in
ProblemList.txt
, as these usually differ between JDK versions.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3150/head:pull/3150
$ git checkout pull/3150
Update a local copy of the PR:
$ git checkout pull/3150
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3150/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3150
View PR using the GUI difftool:
$ git pr show -t 3150
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3150.diff
Using Webrev
Link to Webrev Comment