Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x #3150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Dec 18, 2024

A mostly clean backport of JDK-8294316 to properly parse core files in macOS 12 and later. Load commands with length zero are now discarded.

The fix doesn't affect directly to SA tests in 17, but it's being backported to 11 as this is the cause of openjdk/jdk11u-dev#2967 (comment).

Tests in 17 continue to pass in all platforms, including macos.

The change is not clean as there were merge conflicts in ProblemList.txt, as these usually differ between JDK versions.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8294316 needs maintainer approval

Issue

  • JDK-8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3150/head:pull/3150
$ git checkout pull/3150

Update a local copy of the PR:
$ git checkout pull/3150
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3150/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3150

View PR using the GUI difftool:
$ git pr show -t 3150

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3150.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2024

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 18, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport eaa475f72ced51cf0f0d0bce9ff1265bfb81ab31 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x Dec 18, 2024
@openjdk
Copy link

openjdk bot commented Dec 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 18, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 18, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant