Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory #3106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Dec 11, 2024

Backport of JDK-8343205 from jdk21u-dev.


Progress

  • JDK-8343205 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3106/head:pull/3106
$ git checkout pull/3106

Update a local copy of the PR:
$ git checkout pull/3106
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3106/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3106

View PR using the GUI difftool:
$ git pr show -t 3106

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3106.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 11, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 11, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 3087c6c74d742b7b5eaf28e4c886b5dc1811ea6f 8343205: CompileBroker::possibly_add_compiler_threads excessively polls available memory Dec 11, 2024
@openjdk
Copy link

openjdk bot commented Dec 11, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 11, 2024

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 11, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 11, 2024

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/approval request JDK17 is affected by this performance issue, too. The fix is not complicated and the backport from 21u-dev applies cleanly. Tier1-4 plus extra tests have passed many times. No regression observed.

@openjdk
Copy link

openjdk bot commented Dec 16, 2024

@TheRealMDoerr
8343205: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 16, 2024
@GoeLin
Copy link
Member

GoeLin commented Dec 17, 2024

Hi, the bug says this applies only to linux x86_64, why is this so?
Also, this is at the edge of being applicable to stable 17u. I would like to defer this to the next release to give it some time in 24/21.

@TheRealMDoerr
Copy link
Contributor Author

All platforms are affected, but it is only problematic in environments in which os::free_memory() is slow. That was reported for some kind of container environment on linux x64. I think we should have this fix in 17u because JDK 17u is probably used in such environments, too. I think the risk is low, but we could also ship it one release later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants