8314610: hotspot can't compile with the latest of gtest because of <iomanip>

[Sorna-Sarathi]

Hi all,
This pull request contains a backport of commit febc34d from the openjdk/jdk repository.
Tier1 testing is successful.
Thanks!

JBS Issue: JDK-8314610

---

Progress

• JDK-8314610 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8314610: hotspot can't compile with the latest of gtest because of <iomanip>

Issue

• JDK-8314610: hotspot can't compile with the latest of gtest because of <iomanip> (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2959/head:pull/2959
$ git checkout pull/2959

Update a local copy of the PR:
$ git checkout pull/2959
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2959/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2959

View PR using the GUI difftool:
$ git pr show -t 2959

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2959.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @Sorna-Sarathi, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Sorna-Sarathi" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[Sorna-Sarathi]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[openjdk]

⚠️ @Sorna-Sarathi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (4f987e0e)

[bridgekeeper]

@Sorna-Sarathi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[Sorna-Sarathi]

/approval request fixes hotspot compiling issue with the latest gtest. Backporting it.

[openjdk]

@Sorna-Sarathi
8314610: The approval request has been created successfully.

[GoeLin]

Hi @Sorna-Sarathi
please check the failed GHA tests.
Most of the time they fail because of a problem with the test setup. Nevertheless you need to check this to make sure it's not caused by your backport.
You should in any case comment why it failed. Then you can either restart the tests or just argue that they are not important for the backport you are working on in this PR (if this actually is the case!).
Just restarting without checking the tests is not good as sometimes changes bring sporadic failures ...

[GoeLin]

Removing the approval request tag in the meantime

[bridgekeeper]

@Sorna-Sarathi This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[TheRealMDoerr]

Regarding the GHA failures, I have only seen the "xcode-select: error: invalid developer directory '/Applications/Xcode_14.3.1.app/Contents/Developer'" issue which has been resolved by 82a609d.