8360816: [11u] Use default value for ProgramFiles(x86) in GHA

[vieiro]

A fix for JDK-8360816.

The ProgramFiles(x86) environment variable is not properly propagated to JTReg tests in JDK11, which makes the AOT compiler tests fail on the new windows-2025 GHA runners, as manifested in the backport of https://bugs.openjdk.org/browse/JDK-8358538.

Propagating this environment variable to JTRegs may require creating devkits for Windows 2022, but previous attempts were discarded JDK-8283723.

This fix prints a warning message when this environment variable is not set, and then uses a default value (C:\Program Files (x86)) that makes it possible to run the AOT tests with these new windows-2025 GHA runners. If the ProgramFiles(x86) env variable is set the fix has no effect, ensuring the previous behaviour. If the proposed default value is incorrect the AOT tests will continue to fail as before.

The PR is on top of #3052 to verify the fix works as intended with the new windows-2025 GHA runners.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8360816 needs maintainer approval

Issue

• JDK-8360816: [11u] Use default value for ProgramFiles(x86) in GHA (Bug - P4 - Approved)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3056/head:pull/3056
$ git checkout pull/3056

Update a local copy of the PR:
$ git checkout pull/3056
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3056/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3056

View PR using the GUI difftool:
$ git pr show -t 3056

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3056.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into pr/3052 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vieiro This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8360816: [11u] Use default value for ProgramFiles(x86) in GHA

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 06: Full - Incremental (51e8454a)
• 05: Full - Incremental (d2fa919a)
• 04: Full (0927ca70)
• 03: Full - Incremental (14e3f886)
• 02: Full (a3582975)
• 01: Full - Incremental (4eee33e9)
• 00: Full (4eee33e9)

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout fixes/JDK-8360816
git fetch https://git.openjdk.org/jdk11u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[jerboaa]

Why don't we set the expected ProgramFiles(x86) environment variable to value C:\\Program Files (x86) in the GHA job? This would be a less invasive fix as the code in this PR changes product code.

[vieiro]

Why don't we set the expected ProgramFiles(x86) environment variable to value C:\\Program Files (x86) in the GHA job? This would be a less invasive fix as the code in this PR changes product code.

ProgramFiles(x86) does not comply with naming conventions for configuration variables (but who knows, maybe we can pass it as an environment variable, despite it having parentheses in the name). Also JTReg may refuse to pass that env variable to the test.

I think we could also add a new entry to the VSVERSIONS enum, specific to the 2022 configuration, that also uses default C:\\Program Files (x86) paths, but this will touch product code in any case.

I'll experiment with this and report back.

[openjdk]

@vieiro Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

@vieiro Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[vieiro]

We cannot add a ProgramFiles(x86) environment variable through Github Actions, because JTReg will block it (the list of environment variables that JTReg passes to tests on Windows is very small.

We can instead add it directly to the JTReg options using -eKEY:VALUE, properly escaping the spaces and the backslashes.

This is cleaner (no changes to product code) but it propagates the environment variable on Linux and MacOS.

[jerboaa]

This is cleaner (no changes to product code) but it propagates the environment variable on Linux and MacOS.

Right, but we can fix that too. See my suggested comment.

[vieiro]

Ah, that's clever. Will do that during the week! Thanks!

[vieiro]

Well, this should do it...

[jerboaa]

Seems OK.

[openjdk]

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[vieiro]

/approval request Please consider approving this PR as it makes it possible to pass the AOT compiler tests in GitHub Actions with the latest "windows-2025" runners. Little risk as only the .github files are modified.

[openjdk]

@vieiro
8360816: The approval request has been created successfully.

[vieiro]

/integrate

[openjdk]

@vieiro
Your change (at version 51e8454) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit 646b6b5.

[openjdk]

@jerboaa @vieiro Pushed as commit 646b6b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.