-
Notifications
You must be signed in to change notification settings - Fork 241
8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build #3054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back tkurashige! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean.
/clean |
@kurashige23 The |
Thank you for review. /approval request No risk, only a test change. |
@kurashige23 |
Hi all,
This is a backport of JDK-8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build
I couldn't reproduce the bug reported in JDK-8352942 in 11u but it will potentially happen as described in openjdk/jdk#24646 (comment) . So I think this fix should be backported to 11u.
Original patch applies cleanly to 11u.
Testing: TestMemoryOptions.java executed by 32/64bit module passes and Winsows Server 2019
Thanks.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3054/head:pull/3054
$ git checkout pull/3054
Update a local copy of the PR:
$ git checkout pull/3054
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3054/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3054
View PR using the GUI difftool:
$ git pr show -t 3054
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3054.diff
Using Webrev
Link to Webrev Comment