Skip to content

8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build #3054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kurashige23
Copy link
Member

@kurashige23 kurashige23 commented Jun 24, 2025

Hi all,

This is a backport of JDK-8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build

I couldn't reproduce the bug reported in JDK-8352942 in 11u but it will potentially happen as described in openjdk/jdk#24646 (comment) . So I think this fix should be backported to 11u.

Original patch applies cleanly to 11u.

Testing: TestMemoryOptions.java executed by 32/64bit module passes and Winsows Server 2019

Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8352942 needs maintainer approval

Issue

  • JDK-8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3054/head:pull/3054
$ git checkout pull/3054

Update a local copy of the PR:
$ git checkout pull/3054
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3054/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3054

View PR using the GUI difftool:
$ git pr show -t 3054

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3054.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 24, 2025

👋 Welcome back tkurashige! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 24, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport c3de94cee12471a11c457c11dd55c547633de5cb 8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build Jun 24, 2025
@openjdk
Copy link

openjdk bot commented Jun 24, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 24, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 24, 2025

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@openjdk
Copy link

openjdk bot commented Jun 25, 2025

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean.

@kurashige23
Copy link
Member Author

/clean

@openjdk
Copy link

openjdk bot commented Jun 26, 2025

@kurashige23 The /clean pull request command is not enabled for this repository

@kurashige23
Copy link
Member Author

Thank you for review.

/approval request No risk, only a test change.
Clean backport.
TestMemoryOptions.java executed by 32/64bit module passes on Winsows Server 2019.

@openjdk
Copy link

openjdk bot commented Jun 26, 2025

@kurashige23
8352942: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants