Skip to content

8358538: Update GHA Windows runner to 2025 #3050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Jun 19, 2025

Backport of JDK-8358538 to bump the image version of the Windows GHA Runners from the current windows-2019 (which is being removed by the end of june) to windows-2022.

Note that we're bumping to windows-2022 and not to windows-2025 as in the original commit).

The backport is not clean, because the GHA setup for 11 is different from JDK (and from JDK-17 too).

With this change we're using --with-msvc-toolset-version=14.43 (from the current 14.29) which translates to:

* C Compiler:     Version 19.43.34808 (at /c/progra~1/micros~2/2022/enterp~1/vc/tools/msvc/1443~1.348/bin/hostx86/x64/cl.exe)
* C++ Compiler:   Version 19.43.34808 (at /c/progra~1/micros~2/2022/enterp~1/vc/tools/msvc/1443~1.348/bin/hostx86/x64/cl.exe)

The build seems to work correctly, but some AOT compiler tests fail on Windows ...

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
>> jtreg:test/hotspot/jtreg:tier1_compiler             782   728    54     0 <<
 ==============================
 TEST FAILURE

... stating that the Microsoft Visual Studio linker cannot be found ...

2025-06-19T06:57:52.2058557Z STDERR:
2025-06-19T06:57:52.2059714Z artifact resolution error: jdk.test.lib.artifacts.ArtifactResolverException: Couldn't automatically resolve dependency for devkit-windows_x64 , revision VS2017-15.5.5+1.0
2025-06-19T06:57:52.2061234Z Please specify the location using jdk.test.lib.artifacts.devkit-windows_x64
2025-06-19T06:57:52.2062000Z  stdout: [Compiling AotInvokeDynamic2AotTest.so...
2025-06-19T06:57:52.2062869Z Exception in thread "main" java.lang.InternalError: Can't locate Microsoft Visual Studio amd64 link.exe
2025-06-19T06:57:52.2063952Z 	at [email protected]/jdk.tools.jaotc.Linker.<init>(Linker.java:112)
2025-06-19T06:57:52.2064681Z 	at [email protected]/jdk.tools.jaotc.Main.run(Main.java:160)
2025-06-19T06:57:52.2065355Z 	at [email protected]/jdk.tools.jaotc.Main.run(Main.java:133)
2025-06-19T06:57:52.2066028Z 	at [email protected]/jdk.tools.jaotc.Main.main(Main.java:89)

... which is possibly related to the modifications to Linker.java that were introduced in JDK-8231318. This is JDK11 specific, because the AOT compiler was dropped in JDK-8264805 in JDK-17.

The PR is in draft mode while this is being investigated.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8358538 needs maintainer approval

Issue

  • JDK-8358538: Update GHA Windows runner to 2025 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3050/head:pull/3050
$ git checkout pull/3050

Update a local copy of the PR:
$ git checkout pull/3050
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3050/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3050

View PR using the GUI difftool:
$ git pr show -t 3050

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3050.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 19, 2025

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport b787ff6def08a050b690b60e4a0ceb3aec2b73c8 8358538: Update GHA Windows runner to 2025 Jun 19, 2025
@openjdk
Copy link

openjdk bot commented Jun 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jun 19, 2025
@vieiro
Copy link
Contributor Author

vieiro commented Jun 19, 2025

Attaching the log of the offending tests before converting to draft.
windows-2022-x64-hs_tier1_compiler-log.txt

@vieiro vieiro marked this pull request as draft June 19, 2025 08:07
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jun 19, 2025
@vieiro
Copy link
Contributor Author

vieiro commented Jun 20, 2025

Note 1: The environment variable ProgramFiles(x86) is not being set by GHA/Cygwin? and Linker.java complains, making all AOT compiler tests to fail. Possible workaround is to use a default C:\Program Files(x86) value if the variable is not found.

Note 2: Upper JDK versions with windows-2025 are evaluating MSVC 14.44 in JDK-8360042

@vieiro
Copy link
Contributor Author

vieiro commented Jun 23, 2025

Closing in favor of #3052

@vieiro vieiro closed this Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base
Development

Successfully merging this pull request may close these issues.

1 participant