8358538: Update GHA Windows runner to 2025 #3050
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of JDK-8358538 to bump the image version of the Windows GHA Runners from the current
windows-2019
(which is being removed by the end of june) towindows-2022
.Note that we're bumping to
windows-2022
and not towindows-2025
as in the original commit).The backport is not clean, because the GHA setup for 11 is different from JDK (and from JDK-17 too).
With this change we're using
--with-msvc-toolset-version=14.43
(from the current14.29
) which translates to:The build seems to work correctly, but some AOT compiler tests fail on Windows ...
... stating that the Microsoft Visual Studio linker cannot be found ...
... which is possibly related to the modifications to
Linker.java
that were introduced in JDK-8231318. This is JDK11 specific, because the AOT compiler was dropped in JDK-8264805 in JDK-17.The PR is in draft mode while this is being investigated.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3050/head:pull/3050
$ git checkout pull/3050
Update a local copy of the PR:
$ git checkout pull/3050
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3050/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3050
View PR using the GUI difftool:
$ git pr show -t 3050
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3050.diff