Skip to content

8211804: Constant AO_UNUSED_MBZ uses left shift of negative value #3042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 4, 2025

Hi all,

This pull request contains a backport of commit 51be7db9 from the openjdk/jdk repository.

The commit being backported was authored by Kim Barrett on 9 Oct 2018 and was reviewed by Alan Bateman.

This patch fixes a build error on macOS with Xcode 16.4 that can't be resolved using --disable-warnings-as-errors.

/jdk11u-dev/src/jdk.pack/share/native/common-unpack/constants.h:206:33: error: expression is not an integral constant expression
  206 |     AO_UNUSED_MBZ             = (-1)<<13, // options bits reserved for future use.
      |                                 ^~~~~~~~

Thanks!


Progress

  • JDK-8211804 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8211804: Constant AO_UNUSED_MBZ uses left shift of negative value (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3042/head:pull/3042
$ git checkout pull/3042

Update a local copy of the PR:
$ git checkout pull/3042
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3042/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3042

View PR using the GUI difftool:
$ git pr show -t 3042

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3042.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 4, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 51be7db96f3fc32a7ddb24f8af19fb4fc0577aaf 8211804: Constant AO_UNUSED_MBZ uses left shift of negative value Jun 4, 2025
@openjdk
Copy link

openjdk bot commented Jun 4, 2025

This backport pull request has now been updated with issue and summary from the original commit.

@mrserb mrserb marked this pull request as ready for review June 4, 2025 20:05
@openjdk
Copy link

openjdk bot commented Jun 4, 2025

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 4, 2025
@mrserb
Copy link
Member Author

mrserb commented Jun 4, 2025

/approval request Clean backport. Fix for a broken build on macOS + XCode 16.4

@openjdk
Copy link

openjdk bot commented Jun 4, 2025

@mrserb
8211804: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jun 4, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 4, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant