8224267: JOptionPane message string with 5000+ newlines produces StackOverflowError

[sercher]

Hi all,

Please review the parity backports with 11.0.28-oracle. 8224267 and 8290162 are clean. The functional part of 5074006 applied cleanly in BasicOptionPaneUI.java. The test required to replace the text block (JEP 355 style) with traditional string literals in TestJOptionHTMLTag.java.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8042134 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-5074006 needs maintainer approval
• JDK-8224267 needs maintainer approval
• JDK-8290162 needs maintainer approval

Issues

• JDK-8224267: JOptionPane message string with 5000+ newlines produces StackOverflowError (Bug - P3 - Requested)
• JDK-8290162: Reset recursion counter missed in fix of JDK-8224267 (Bug - P4 - Requested)
• JDK-5074006: Swing JOptionPane shows </html> tag as a string after newline (Bug - P4 - Requested)
• JDK-8042134: JOptionPane bungles HTML messages (Bug - P4 - Requested)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3036/head:pull/3036
$ git checkout pull/3036

Update a local copy of the PR:
$ git checkout pull/3036
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3036/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3036

View PR using the GUI difftool:
$ git pr show -t 3036

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3036.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back schernyshev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @sercher This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (f947402e)
• 00: Full (bc41986e)

[mrserb]

do you plan to backport https://bugs.openjdk.org/browse/JDK-8290162 as well?

[sercher]

do you plan to backport https://bugs.openjdk.org/browse/JDK-8290162 as well?

@mrserb yes, 8290162 and 5074006, that depend on this one.

[sercher]

/approval request Parity backport with 11.0.28-oracle,
This affects 8 and 11,
This is a clean backport,
The test passes with the fix and fails otherwise.

[openjdk]

@sercher
8224267: The approval request has been created successfully.

[sercher]

/issue add 8290162,5074006

[openjdk]

@sercher
Adding additional issue to issue list: 8290162: Reset recursion counter missed in fix of JDK-8224267.

Adding additional issue to issue list: 5074006: Swing JOptionPane shows </html> tag as a string after newline.

[sercher]

/issue add 8042134

[openjdk]

@sercher
Adding additional issue to issue list: 8042134: JOptionPane bungles HTML messages.