Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8341424: GHA: Collect hs_errs from build time failures #2982

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Jan 2, 2025

Backport of JDK-8341424 and companion JDK-8342704

This collects hs_errs when they happen with GitHub Actions, which may be useful during reviews.

Low risk, as this affects GHA actions only. GHA builds and tests run correctly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8342704 needs maintainer approval
  • JDK-8341424 needs maintainer approval

Issues

  • JDK-8341424: GHA: Collect hs_errs from build time failures (Enhancement - P4 - Requested)
  • JDK-8342704: GHA: Report truncation is broken after JDK-8341424 (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2982/head:pull/2982
$ git checkout pull/2982

Update a local copy of the PR:
$ git checkout pull/2982
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2982/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2982

View PR using the GUI difftool:
$ git pr show -t 2982

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2982.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 2, 2025

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 2, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 3bc06ab80f09b57dc10b182d9bc1ab1584cf6706 8341424: GHA: Collect hs_errs from build time failures Jan 2, 2025
@openjdk
Copy link

openjdk bot commented Jan 2, 2025

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 2, 2025

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 2, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 2, 2025

Webrevs

@vieiro
Copy link
Contributor Author

vieiro commented Jan 2, 2025

Build failures are unrelated and are due to

@vieiro
Copy link
Contributor Author

vieiro commented Jan 2, 2025

/approval request Let's keep these hs_err files when they are generated. This may prove valuable in the future.

@openjdk
Copy link

openjdk bot commented Jan 2, 2025

@vieiro
8341424: The approval request has been created successfully.
8342704: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant