-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8341424: GHA: Collect hs_errs from build time failures #2982
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issues from the original commit. |
|
Build failures are unrelated and are due to
|
/approval request Let's keep these hs_err files when they are generated. This may prove valuable in the future. |
Backport of JDK-8341424 and companion JDK-8342704
This collects hs_errs when they happen with GitHub Actions, which may be useful during reviews.
Low risk, as this affects GHA actions only. GHA builds and tests run correctly.
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2982/head:pull/2982
$ git checkout pull/2982
Update a local copy of the PR:
$ git checkout pull/2982
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2982/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2982
View PR using the GUI difftool:
$ git pr show -t 2982
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2982.diff
Using Webrev
Link to Webrev Comment