-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8231058: VerifyOops crashes with assert(_offset >= 0) failed: offset for non comment? #2963
base: master
Are you sure you want to change the base?
Conversation
…for non comment? Offset method should only be called for comments. Reviewed-by: roland, dholmes
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue and summary from the original commit. |
|
/approval request Clean backport of JDK-8231058, to fix JVM crash when running with -XX:+VerifyOops. The newly added test run failed before this backport, and run passed after apply this backport. The change has been verified with jtreg(include tier1/2/3 etc.) on linux-x64 and linux-aarch64. |
@sendaoYan |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/approval request Clean backport of JDK-8231058, to fix JVM crash when running with -XX:+VerifyOops. The newly added test run failed before this backport, and run passed after apply this backport. The change has been verified with jtreg(include tier1/2/3 etc.) on linux-x64 and linux-aarch64. |
@sendaoYan |
Hi all,
This is clean backport of JDK-8231058, to fix JVM crash when running with
-XX:+VerifyOops
. The newly added test run failed before this backport, and run passed after apply this backport.Additonal testing:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2963/head:pull/2963
$ git checkout pull/2963
Update a local copy of the PR:
$ git checkout pull/2963
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2963/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2963
View PR using the GUI difftool:
$ git pr show -t 2963
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2963.diff
Using Webrev
Link to Webrev Comment