Skip to content

8358183: [JVMCI] crash accessing nmethod::jvmci_name in CodeCache::aggregate #25608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bulasevich
Copy link
Contributor

@bulasevich bulasevich commented Jun 3, 2025

This change addresses an intermittent crash in CompileBroker::print_heapinfo() when accessing JVMCI metadata after a CodeBlob::purge().

The issue is a regression after:

  • JDK-8343789: JVMCI metadata was moved from nmethod into a separate blob.
  • JDK-8352112: CodeBlob::purge() was updated to set _mutable_data to blob_end().

The change zeroes out _mutable_data_size, _relocation_size, and _metadata_size in purge() so that after purge jvmci_data_size() returns 0 and CompileBroker::print_heapinfo() won’t touch an invalid _metadata.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358183: [JVMCI] crash accessing nmethod::jvmci_name in CodeCache::aggregate (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25608/head:pull/25608
$ git checkout pull/25608

Update a local copy of the PR:
$ git checkout pull/25608
$ git pull https://git.openjdk.org/jdk.git pull/25608/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25608

View PR using the GUI difftool:
$ git pr show -t 25608

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25608.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 3, 2025

👋 Welcome back bulasevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 3, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jun 3, 2025

@bulasevich The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@bulasevich bulasevich marked this pull request as ready for review June 4, 2025 04:35
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 4, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 4, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant