8358171: Additional code coverage for PEM API #25588
Open
+532
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@fguallini The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
mpdonova
reviewed
Jun 3, 2025
ascarpino
reviewed
Jun 5, 2025
turbanoff
reviewed
Jun 5, 2025
| String algorithm = switch(privateKey.getAlgorithm()) { | ||
| case "EC" -> "SHA256withECDSA"; | ||
| case "EdDSA" -> "EdDSA"; | ||
| case "RSASSA-PSS" -> { |
There was a problem hiding this comment.
Suggested change
| case "RSASSA-PSS" -> { | |
| case "RSASSA-PSS" -> { |
turbanoff
reviewed
Jun 5, 2025
|
|
||
| public static void main(String[] args) throws Exception { | ||
| PEMEncoder encoder = PEMEncoder.of(); | ||
| try(ExecutorService ex = Executors.newFixedThreadPool(THREAD_COUNT)) { |
There was a problem hiding this comment.
Suggested change
| try(ExecutorService ex = Executors.newFixedThreadPool(THREAD_COUNT)) { | |
| try (ExecutorService ex = Executors.newFixedThreadPool(THREAD_COUNT)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests included in this PR add code coverage mainly to the following classes introduced/updated by JEP 470 (PEM): PEMDecoder, PEMEncoder, Pem, EncryptedPrivateKeyInfo and the Key factories. In addition, more tests are included for RSAPSS, multithreading, jdk.epkcs8.defaultAlgorithm property and some negative testing
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25588/head:pull/25588$ git checkout pull/25588Update a local copy of the PR:
$ git checkout pull/25588$ git pull https://git.openjdk.org/jdk.git pull/25588/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25588View PR using the GUI difftool:
$ git pr show -t 25588Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25588.diff
Using Webrev
Link to Webrev Comment