Skip to content

8356438: Update OutputAnalyzer to optionally print process output as it happens #25587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

friedbyalice
Copy link

@friedbyalice friedbyalice commented Jun 2, 2025

The implemented solution modifies the OutputBuffer implementation instead of the OutputAnalyzer implementation.
This is because the OutputBuffer implementation which handles processes (LazyOutputBuffer) starts a thread in its constructor, so we would need to add a strange additional constructor parameter to the OutputBuffer.of(Process, Charset) static method, while the printing through to stdout (and stderr) only makes sense for LazyOutputBuffer.

I believe changing the config option from outputanalyzer.verbose to output buffer.verbose would make it cleaner, and avoid referencing the OutputAnalyzer in the OutputBuffer implementation.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8356438: Update OutputAnalyzer to optionally print process output as it happens (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25587/head:pull/25587
$ git checkout pull/25587

Update a local copy of the PR:
$ git checkout pull/25587
$ git pull https://git.openjdk.org/jdk.git pull/25587/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25587

View PR using the GUI difftool:
$ git pr show -t 25587

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25587.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 2, 2025

👋 Welcome back friedbyalice! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 2, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jun 2, 2025

@friedbyalice The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@friedbyalice friedbyalice force-pushed the 8356438-outputanalyzer-optional-print branch from d285676 to b51f0d4 Compare June 2, 2025 12:02
@friedbyalice friedbyalice marked this pull request as ready for review June 5, 2025 09:20
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 5, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 5, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants