8323100: com/sun/tools/attach/StartManagementAgent.java failed with "WaitForSingleObject failed"

[dholmes-ora]

See bug report for gory details.

Short version: in the Windows version of VirtualMachineImpl::execute, if an exception occurred after we created the SocketInputStreamImpl (which is the test scenario of the failing test), we would close the native HANDLE to the pipe twice. But after the first close the HANDLE could be reassigned to another object (e.g. the _ParkHandle of the StreamPumper thread) and the second close would close that HANDLE resulting in the failure of WaitForSingleObject. (Other failure modes with different invalid handles have also been seen.)

Fix: shorten the outer try/catch block so that we only directly close the pipe if the IOException happens before we create the SocketStreamImpl - after which the closing of the stream will close the pipe HANDLE.

Testing:

• ran the com/sun/tools/attach tets group 2500 times without failure
• tiers 3-5 as a sanity check (Windows only)

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8323100: com/sun/tools/attach/StartManagementAgent.java failed with "WaitForSingleObject failed" (Bug - P3)

Reviewers

• Kevin Walls (@kevinjwalls - Reviewer)
• Alex Menkov (@alexmenkov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24346/head:pull/24346
$ git checkout pull/24346

Update a local copy of the PR:
$ git checkout pull/24346
$ git pull https://git.openjdk.org/jdk.git pull/24346/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24346

View PR using the GUI difftool:
$ git pr show -t 24346

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24346.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323100: com/sun/tools/attach/StartManagementAgent.java failed with "WaitForSingleObject failed"

Reviewed-by: kevinw, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 07fd666: 8342984: Bump minimum boot jdk to JDK 24
• 6a46d55: 8353129: CDS ArchiveRelocation tests fail after JDK-8325132
• 19eabaf: 8353227: JFR: Prepare tests for strong parser validation
• 564066d: 8353118: Deprecate the use of java.locale.useOldISOCodes system property
• a1ab1d8: 8353449: [BACKOUT] One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683
• 2a31f69: 8353331: Test ForkJoinPool20Test::testFixedDelaySequence is failing
• 1809138: 8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files
• cef5610: 8353272: One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683
• 6801eb8: 8352709: Remove bad timing annotations from WhileOpTest.java
• 85a0baf: 8352719: Add an equals sign to the modules statement
• ... and 5 more: https://git.openjdk.org/jdk/compare/860a789e9153448345f19d70dd07e294a0b62223...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ae0b34eb)

[kevinjwalls]

Excellent to have this found, they just looked like an "impossible" failures. 8-)

Also good lessons in naming and commenting around processCompletionStatus.

[dholmes-ora]

Thanks for the review @kevinjwalls !

[dholmes-ora]

Thanks for the review @alexmenkov !

/integrate

[openjdk]

Going to push as commit e6fe249.
Since your change was applied there have been 19 commits pushed to the master branch:

• 096e70d: 8352437: Support --add-exports with -XX:+AOTClassLinking
• 6970cf6: 8352775: JVM crashes with -XX:AOTMode=create -XX:+UseZGC
• afcad8c: 5043343: FileImageInputStream and FileImageOutputStream do not properly track streamPos for RandomAccessFile
• 6891490: 8353324: Clean up of comments and import after 8319192
• 07fd666: 8342984: Bump minimum boot jdk to JDK 24
• 6a46d55: 8353129: CDS ArchiveRelocation tests fail after JDK-8325132
• 19eabaf: 8353227: JFR: Prepare tests for strong parser validation
• 564066d: 8353118: Deprecate the use of java.locale.useOldISOCodes system property
• a1ab1d8: 8353449: [BACKOUT] One instance of STATIC_LIB_CFLAGS was missed in JDK-8345683
• 2a31f69: 8353331: Test ForkJoinPool20Test::testFixedDelaySequence is failing
• ... and 9 more: https://git.openjdk.org/jdk/compare/860a789e9153448345f19d70dd07e294a0b62223...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora Pushed as commit e6fe249.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.