8346907: [CRaC] Print RESTORE_SETTABLE marker

[jankratochvil]

Author is @AntonKozlov I believe.

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8346907: [CRaC] Print RESTORE_SETTABLE marker (Enhancement - P4)

Reviewers

• Timofei Pushkin (@TimPushkin - Author)
• Radim Vansa (@rvansa - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/158/head:pull/158
$ git checkout pull/158

Update a local copy of the PR:
$ git checkout pull/158
$ git pull https://git.openjdk.org/crac.git pull/158/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 158

View PR using the GUI difftool:
$ git pr show -t 158

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/158.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346907: [CRaC] Print RESTORE_SETTABLE marker

Reviewed-by: tpushkin, rvansa

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the crac branch:

• 606a9cd: 8347055: [CRaC] Remote JMX support
• eed291a: 8347056: [CRaC] Propagating CRaC events to JVMTI agents

Please see this link for an up-to-date comparison between the source branch of this pull request and the crac branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rvansa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 01: Full - Incremental (ab96513d)
• 00: Full (04aea0b8)

[bridgekeeper]

@jankratochvil This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[TimPushkin]

/issue JDK-8346907

[openjdk]

@TimPushkin Only the author (@jankratochvil) is allowed to issue the /issue command.

[TimPushkin]

LGTM.

I've filed a JBS issue for it so I think the PR should be renamed accordingly ("8346907: [CRaC] Print RESTORE_SETTABLE marker") and maybe /issue JDK-8346907 will be neded if Skara won't find the issue automatically after the renaming.

[jankratochvil]

/issue JDK-8346907

[openjdk]

@jankratochvil The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

[rvansa]

LGTM, thanks!

[rvansa]

Actually the test does not compile:

/home/runner/work/crac/crac/test/jdk/jdk/crac/CracRestoreSettablePrintFlags.java:34: error: cannot find symbol
        ProcessBuilder pb = ProcessTools.createTestJavaProcessBuilder(
                                        ^
  symbol:   method createTestJavaProcessBuilder(String,String)
  location: class ProcessTools

[TimPushkin]

The PR needs to be rebased on top of the current crac branch where it should compile fine. Skara should do that automatically but it would be safer if @jankratochvil just updated his branch.

[jankratochvil]

==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk/jdk/crac/CracRestoreSettablePrintFlags.java
                                                         1     1     0     0   
==============================

[TimPushkin]

Looks like it's good now

[jankratochvil]

/integrate

[openjdk]

@jankratochvil
Your change (at version ab96513) is now ready to be sponsored by a Committer.

[rvansa]

/sponsor

[openjdk]

Going to push as commit 27ce88b.
Since your change was applied there have been 2 commits pushed to the crac branch:

• 606a9cd: 8347055: [CRaC] Remote JMX support
• eed291a: 8347056: [CRaC] Propagating CRaC events to JVMTI agents

Your commit was automatically rebased without conflicts.

[openjdk]

@rvansa @jankratochvil Pushed as commit 27ce88b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.