defining Session Key Computation parameters #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
commented
Oct 5, 2022
| * info: “SKVerifier” (encoded as ASCII string) | ||
| * L: 32 octets | ||
| * IKM: Zab // discuss | ||
| * salt: SHA-256(???) // discuss |
There was a problem hiding this comment.
Suggested change
| * salt: SHA-256(???) // discuss | |
| * salt: SHA-256(XOR(nonce, PubKey)) |
nonce is combination of pieces from both parties.
There was a problem hiding this comment.
plan to derive 16 bytes :)
Sakurann
commented
Oct 5, 2022
| * salt: SHA-256 | ||
| * info: “SKVerifier” (encoded as ASCII string) | ||
| * L: 32 octets | ||
| * IKM: Zab // discuss |
There was a problem hiding this comment.
Suggested change
| * IKM: Zab // discuss | |
| * IKM: Zab |
There was a problem hiding this comment.
two pubkeys -> secret key -> input for IKM
gsasikumar
requested changes
Oct 18, 2022
| * salt: SHA-256 | ||
| * info: “SKWallet” (encoded as ASCII string) | ||
| * L: 32 octets | ||
| * IKM: Zab // discuss |
There was a problem hiding this comment.
IKM: Shared secret key created using RFC7748 for X25519.
| * info: “SKWallet” (encoded as ASCII string) | ||
| * L: 32 octets | ||
| * IKM: Zab // discuss | ||
| * salt: SHA-256(???) // discuss |
There was a problem hiding this comment.
salt: concatenate 8byte of nonce from the wallet and 8 bytes of nonce from relying party. So total of 16 bytes
| * IKM: Zab // discuss | ||
| * salt: SHA-256(???) // discuss | ||
| * info: “OpenID4VPVerifier” (encoded as ASCII string) | ||
| * L: 32 octets // discuss | ||
|
|
||
| The Wallet MUST derive session key using HKDF as defined in [RFC5869] with the following parameters: | ||
|
|
||
| * Hash: SHA-256 |
There was a problem hiding this comment.
Why did we choose SHA-256? Blake2b is a far better hashing algorithm and is performance friendly RFC 7693
. Note: Argon uses Blake2b .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.