-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: section Media Type Registration for wallet-attestation+jwt #86
Open
peppelinux
wants to merge
9
commits into
openid:main
Choose a base branch
from
peppelinux:mtr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
830780a
feat: section Metia Type Registration for wallet-attestation+jwt
peppelinux 51770ba
fix: doc refs
peppelinux 0ba9fbf
fix: doc refs - again
peppelinux 2986125
fix: doc refs - again and again
peppelinux 6ca552f
Apply suggestions from code review - Torsten's
e9c664c
Apply suggestions from code review
c51613a
Apply suggestions from code review
96a3b80
kristina proposed to move & with &
6550280
Merge branch 'main' into mtr
peppelinux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -374,6 +374,36 @@ Note: When using this profile with other cryptosuites, it is recommended to be e | |
|
||
`iat` and `exp` JWT claims express both the validity period of both the signature and the claims about the subject, unless there is a separate claim used to express the validity of the claims. | ||
|
||
|
||
## Media Type Registration | ||
|
||
This section requests registration of the following media types [@RFC2046] in | ||
the ["Media Types" registry](https://www.iana.org/assignments/media-types/media-types.xhtml#application) in the manner described | ||
in [@RFC6838]. | ||
|
||
To indicate that the content of a JWS is a Wallet Attestation: | ||
|
||
* Type name: application | ||
* Subtype name: wallet-attestation+jwt | ||
* Required parameters: n/a | ||
* Optional parameters: n/a | ||
* Encoding considerations: binary; A JWT-based Wallet Attestation object is a JWT; JWT values are encoded as a series of base64url-encoded values (some of which may be the empty string) separated by period ('.') characters. | ||
* Security considerations: See (#security-considerations) of [[ this specification ]] | ||
peppelinux marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* Interoperability considerations: n/a | ||
* Published specification: [[ this specification ]] | ||
* Applications that use this media type: Applications using [[ this specification ]] for issuing and validating Wallet Instance Attestations. | ||
* Fragment identifier considerations: n/a | ||
* Additional information: | ||
* File extension(s): n/a | ||
* Macintosh file type code(s): n/a | ||
* Person & email address to contact for further information: Torsten Lodderstedt, [email protected] | ||
peppelinux marked this conversation as resolved.
Show resolved
Hide resolved
|
||
* Intended usage: COMMON | ||
* Restrictions on usage: none | ||
* Author: Torsten Lodderstedt | ||
* Change controller: IETF | ||
* Provisional registration? No | ||
|
||
|
||
{backmatter} | ||
|
||
<reference anchor="OIDF.OID4VCI" target="https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0.html"> | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this attestation is defined in Section {#wallet-attestation-schema}, security considerations related to the attestation should be specified there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have changed the link/ref to #wallet-attestation-schema