-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define entity_statement_signing_alg_values_supported metadata parameter #81
Open
selfissued
wants to merge
4
commits into
openid:main
Choose a base branch
from
selfissued:mbj-entity-statement-signing-algs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8954081
Define entity_statement_signing_alg_values_supported metadata parameter
selfissued d504cc5
Merge branch 'main' into mbj-entity-statement-signing-algs
selfissued cae75be
Merge branch 'main' of https://github.com/openid/federation into mbj-…
selfissued 0c58e9a
Move history entry to -40
selfissued File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -475,6 +475,9 @@ | |
The Entity Statement is signed using one of the private keys of the issuer | ||
Entity in the form of a <xref target="RFC7515">JSON Web Signature | ||
(JWS)</xref>. | ||
Signing algorithms supported by the Entity MAY be declared using the | ||
<spanx style="verb">entity_statement_signing_alg_values_supported</spanx> | ||
Federation Entity metadata parameter defined in <xref target="federation_entity"/>. | ||
Implementations SHOULD support signature verification with | ||
the RSA SHA-256 algorithm because OpenID Connect Core | ||
requires support for it (<spanx style="verb">alg</spanx> | ||
|
@@ -1232,6 +1235,14 @@ | |
All Federation Entities MAY publish a | ||
<spanx style="verb">federation_historical_keys_endpoint</spanx>. | ||
</t> | ||
<t hangText="entity_statement_signing_alg_values_supported"> | ||
<vspace/> | ||
OPTIONAL. | ||
JSON array containing a list of the JWS signing algorithms | ||
(<spanx style="verb">alg</spanx> values) | ||
supported by the Entity to sign Entity Statements. | ||
If omitted, the default value is <spanx style="verb">["RS256"]</spanx>. | ||
</t> | ||
</list> | ||
</t> | ||
<t> | ||
|
@@ -1241,7 +1252,7 @@ | |
</t> | ||
<figure> | ||
<preamble> | ||
The following is a non-normative example of the <spanx style="verb">federation_entity</spanx> Entity Type: | ||
The following is a non-normative example of metadata for the <spanx style="verb">federation_entity</spanx> Entity Type: | ||
</preamble> | ||
<name> | ||
Example of <spanx style="verb">federation_entity</spanx> Entity Type | ||
|
@@ -1254,6 +1265,10 @@ | |
"https://amanita.caesarea.example.com/federation_list", | ||
"federation_trust_mark_status_endpoint": "https://amanita.caesarea.example.com/status", | ||
"federation_trust_mark_list_endpoint": "https://amanita.caesarea.example.com/trust_marked_list", | ||
"entity_statement_signing_alg_values_supported": [ | ||
"ES256", | ||
"RS256" | ||
], | ||
"organization_name": "Ovulo Mushroom", | ||
"homepage_uri": "https://amanita.caesarea.example.com" | ||
} | ||
|
@@ -5356,6 +5371,10 @@ Content-Type: application/json | |
"federation_entity": { | ||
"contacts": ["[email protected]"], | ||
"federation_fetch_endpoint": "https://sunet.se/openid/fedapi", | ||
"entity_statement_signing_alg_values_supported": [ | ||
"ES256", | ||
"ES384" | ||
], | ||
"homepage_uri": "https://www.sunet.se", | ||
"organization_name": "SUNET" | ||
}, | ||
|
@@ -9825,7 +9844,8 @@ Host: op.umu.se | |
-40 | ||
<list style="symbols"> | ||
<t> | ||
TBD | ||
Fixed #65: Defined <spanx style="verb">entity_statement_signing_alg_values_supported</spanx> | ||
Federation Entity metadata parameter. | ||
</t> | ||
</list> | ||
</t> | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On its own, the definition of this parameter is okay. However, having this parameter parameter defined would not be sufficient for the entities in a federation to be able to use a specific JWS algorithm when more than one is supported. People will ask - what do we do with this parameter? How do I get an ES signed with say ES256 when RS256 and ES256 are supported?