Added unique resource IDs per owner #177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current decision*.json files, the same todo ID is used when checking if users
can_update_todo
when a specific user is the owner. This implies that the same Todo item is owned by different users, which is probably not intended.This PR updates the decision*.json files to use unique todo:id identifiers for todo items owned by different users:
In addition of making it more correct, it simplifies the implementation in ReBAC systems, as they can store the { user:x, owner, todo:y } relation in the database instead of obtaining it from the context.