Advanced flow #52

tlodderstedt · 2023-09-27T09:52:08Z

This is the first revision of the advanced flow (issue #45). Based on the feedback on the issue, I called the wallet request Discovery Request. The verifier may require the wallet to authenticate. It will do so be responding with a HTTP status code 401, the response also provides a nonce to be included in the proof of possession.

Open Topic: Do we want to support plain JSON presentation requests?

peppelinux · 2023-09-27T22:49:20Z

Plain JSON request doesn't seems to satisfy the eudi wallet requirements but I think that openid4vp Will be used also for other Networks and use cases

The wallet that send a plain JSON request to an RP that doesn't support it should obtain a 400 http error with the error identifier and an error_description

peppelinux

A more accurate revision Is needed, there are some details to be further explored and consolidated but I like the main line, in particular the way the nonce is provided. At a first glance!

openid-4-verifiable-presentations-1_0.md

Sakurann · 2023-09-28T19:04:43Z

openid-4-verifiable-presentations-1_0.md

@@ -215,6 +215,53 @@ Figure: Cross Device Flow

 (3) The Wallet prepares the Verifiable Presentation(s) of the Verifiable Credential(s) that the End-User has consented to. It then sends to the Verifier an Authorization Response where the Verifiable Presentation(s) are contained in the `vp_token` parameter.

+## Advanced Flow with Wallet Capabilities Discovery {#adv_flow}
+
+Below is a diagram of a flow where the End-User presents a Credential to a Verifier interacting with the End-User on a different device as the device the Wallet resides on. In this case, the Verifier starts the flow by discovering the Wallet's capabilities through an additional message exchange. This is especially useful, if the Verifier starts the process using a URL serving as alias for a group of wallets (e.g. a custom scheme) but would like to tailor the presentation request to the particular wallet. 


Suggested change

Below is a diagram of a flow where the End-User presents a Credential to a Verifier interacting with the End-User on a different device as the device the Wallet resides on. In this case, the Verifier starts the flow by discovering the Wallet's capabilities through an additional message exchange. This is especially useful, if the Verifier starts the process using a URL serving as alias for a group of wallets (e.g. a custom scheme) but would like to tailor the presentation request to the particular wallet.

Below is a diagram of a flow where the Verifier starts the flow by discovering the Wallet's capabilities through an additional message exchange. This is especially useful, if the Verifier starts the process using a URL serving as alias for a group of Wallets (e.g. a custom scheme) but would like to tailor the presentation request to the particular Wallet. This example uses cross-device flow where the End-User presents a Credential to a Verifier interacting with the End-User on a different device as the device the Wallet resides on.

I would emphasize the wallet capability selection part as opposed to starting with cross-device description.

"different device as the device the Wallet resides on" -> "different device than the device that the Wallet resides on" maybe reads more clearly (or maybe it's just me). So:

Suggested change

Below is a diagram of a flow where the End-User presents a Credential to a Verifier interacting with the End-User on a different device as the device the Wallet resides on. In this case, the Verifier starts the flow by discovering the Wallet's capabilities through an additional message exchange. This is especially useful, if the Verifier starts the process using a URL serving as alias for a group of wallets (e.g. a custom scheme) but would like to tailor the presentation request to the particular wallet.

Below is a diagram of a flow where the Verifier starts the flow by discovering the Wallet's capabilities through an additional message exchange. This is especially useful, if the Verifier starts the process using a URL serving as alias for a group of Wallets (e.g. a custom scheme) but would like to tailor the presentation request to the particular Wallet. This example uses cross-device flow where the End-User presents a Credential to a Verifier interacting with the End-User on a different device than the device that the Wallet resides on.

I made a mistake, as the flow obviously is same device.
The sentence (and with that the order of things) was copied from the other flows. It just spells out the fact that this is a same device flow.
Changed the text to refer to the same device flow instead of duplicating text.

please check

openid-4-verifiable-presentations-1_0.md

Sakurann · 2023-09-28T16:13:33Z

examples/discovery/discover.json

+{
+    "presentation_request_uri": "verifier.example.com/presentation_request",
+    "context": "register_kyc"
+}


could these kind of small examples be in the text and not as a separate file..?

is this file even used? looks like it's inline already at https://github.com/openid/OpenID4VP/pull/52/files?diff=unified&w=0#diff-3118c9756a1d7b361bb53af8bd9d65666476a27cfeeced56c47a5dccc38eac55R294

it is inline, I just used to file to format the example - can remove it once we merge

openid-4-verifiable-presentations-1_0.md

Sakurann · 2023-09-28T19:02:49Z

openid-4-verifiable-presentations-1_0.md

@@ -215,6 +215,53 @@ Figure: Cross Device Flow

 (3) The Wallet prepares the Verifiable Presentation(s) of the Verifiable Credential(s) that the End-User has consented to. It then sends to the Verifier an Authorization Response where the Verifiable Presentation(s) are contained in the `vp_token` parameter.

+## Advanced Flow with Wallet Capabilities Discovery {#adv_flow}


Suggested change

## Advanced Flow with Wallet Capabilities Discovery {#adv_flow}

## Cross Device Flow with Wallet Capabilities Discovery {#adv_flow}

Not sure I am a big fan of "advance flow" term - feels too abstract.

Yes, I'd tend to not use comparative terms like advanced or High or anything that might produce a relation or reference to something lower or feature-less

I think the way this section is written right now does not exactly convey why this is an "advanced" flow. maybe i am misunderstanding something but I would expect more focus on the new ability for the wallet to communicate its capabilities/endpoint/attestation

Advanced is the title of the PR, now it seems it will be a discovery (pre-step). Changed title and first sentence.

Sakurann · 2023-09-28T19:04:43Z

openid-4-verifiable-presentations-1_0.md

@@ -215,6 +215,53 @@ Figure: Cross Device Flow

 (3) The Wallet prepares the Verifiable Presentation(s) of the Verifiable Credential(s) that the End-User has consented to. It then sends to the Verifier an Authorization Response where the Verifiable Presentation(s) are contained in the `vp_token` parameter.

+## Advanced Flow with Wallet Capabilities Discovery {#adv_flow}
+
+Below is a diagram of a flow where the End-User presents a Credential to a Verifier interacting with the End-User on a different device as the device the Wallet resides on. In this case, the Verifier starts the flow by discovering the Wallet's capabilities through an additional message exchange. This is especially useful, if the Verifier starts the process using a URL serving as alias for a group of wallets (e.g. a custom scheme) but would like to tailor the presentation request to the particular wallet. 


Suggested change

Below is a diagram of a flow where the End-User presents a Credential to a Verifier interacting with the End-User on a different device as the device the Wallet resides on. In this case, the Verifier starts the flow by discovering the Wallet's capabilities through an additional message exchange. This is especially useful, if the Verifier starts the process using a URL serving as alias for a group of wallets (e.g. a custom scheme) but would like to tailor the presentation request to the particular wallet.

Below is a diagram of a flow where the Verifier starts the flow by discovering the Wallet's capabilities through an additional message exchange. This is especially useful, if the Verifier starts the process using a URL serving as alias for a group of Wallets (e.g. a custom scheme) but would like to tailor the presentation request to the particular Wallet. This example uses cross-device flow where the End-User presents a Credential to a Verifier interacting with the End-User on a different device as the device the Wallet resides on.

I would emphasize the wallet capability selection part as opposed to starting with cross-device description.

peppelinux · 2023-09-29T16:30:24Z

@tlodderstedt

Here are the elements that come to mind:

An RP or a Wallet Instance acting as a Verifier, should provide wallet discovery endpoint, be this a www https url (RP) or a universal-link/url-scheme (Wallet)
wallet discovery endpoint should issue a discovery nonce, called d_nonce
the wallet discovery endpoint may be not supported by RP that doesn't require this assurance level related to the wallet capabilities, the proposed flow below simplify things while a distinction between the wallet discovery endpoint and a flow discovery endpoint might be useful

I would like to simplify and at the same time give more guidance to the implementers, then I would remove presentation_uri, v_nonce, w_nonce, context giving in addition details about cross-device and same-device flows

This is the flow that I have in mind:

peppelinux · 2023-09-29T16:56:10Z

WDYT about changinc the name from "Advanced flow" to "Wallet ~~Capabilities~~ Discovery flow"?

Sakurann · 2023-10-03T17:33:07Z

openid-4-verifiable-presentations-1_0.md

+        |                 |  (Presentation Request URI)                       |
+        |                 |-------------------------------------------------->|
+        |                 |                                                   |
+        |                 |  (2) Request the Request Object                   |


I think (2) is mainly a "Discovery Response", that also happens to trigger request object from the verifier.

there is discovery, but the result is a request object

this reminds me the italian flow where we have mixed the provisioning of the wia with DPoP to the request_uri endpoint.

We are looking for a better specialization of the endpoints, then the proposed, alternative, flow was provided in this comment: #52 (comment)

Sakurann · 2023-10-03T17:46:29Z

openid-4-verifiable-presentations-1_0.md

+        |                 |<--------------------------------------------------|
+~~~
+!---
+Figure: Cross Device Flow


Suggested change

Figure: Cross Device Flow

Figure: Wallet Discovery Flow

changed to "Same Device Flow with Wallet Capabilities Discovery"

I would like to cover both cross device and same device within this PR

an alternative flow was provided aiming to satisfy this: #52 (comment)

openid-4-verifiable-presentations-1_0.md

Sakurann · 2023-10-03T18:01:43Z

openid-4-verifiable-presentations-1_0.md

@@ -228,6 +275,84 @@ OpenID for Verifiable Presentations extends existing OAuth 2.0 mechanisms as fol

 Presentation of Verifiable Credentials using OpenID for Verifiable Presentations can be combined with the user authentication using [@SIOPv2], and the issuance of OAuth 2.0 Access Tokens.

+# Discovery Request
+
+The Discovery Request allows Verifers to discover the Wallet's capabilities before they create the actual presentation request. It also allows the Wallet to authenticate towards the Verifier and to provide the Verifier with additional data used in the creation of the request signature and to encrypt the request at the application layer (if needed).


Suggested change

The Discovery Request allows Verifers to discover the Wallet's capabilities before they create the actual presentation request. It also allows the Wallet to authenticate towards the Verifier and to provide the Verifier with additional data used in the creation of the request signature and to encrypt the request at the application layer (if needed).

The Discovery Request allows Verifeirs to discover the information about the Wallet before creating the actual presentation request. It allows the Wallet to optionally authenticate towards the Verifier and to provide with additional data such as its endpoint and capabilities. This enables the Verifier to sign the request using the algorithm that the Wallet is guaranteed to support and if needed encrypt the request at the application layer.

in my mind, wallet's endpoint, wallet's capabilities, and wallet attestation are three different things, and I am not sure "wallet capabilities" can be used to express them all

I assume that the wallet instance attestation contains the wallet's capabilities, materially defined with:

cnf.jwk (any other cnf.*)

NiST's AAL (the equivalence of the italian attested_security_contexts)

Authorization Server metadata

other wallet instance metadata, as client_metadata when a wallet instance acts like a Verifier.

@Sakurann those three things are differentiated in the current text. wallet capabilities is in the first sentence, authentication in the second sentence

@peppelinux I assume the capabilities are conveyed using wallet metadata. I agree, there can be other ways. Let's discuss how we can support them.

openid-4-verifiable-presentations-1_0.md

Sakurann · 2023-10-03T18:53:49Z

openid-4-verifiable-presentations-1_0.md

+`presentation_request_uri`:
+: A string containing an HTTPS URL pointing to a resource under the control of the Verifier where the Wallet is supposed to obtain the presentation request object. 


I don't think presentation_request_uri parameter name could be more explicit and differentiate it more clearly from request_uri in rfc9101..? something like discovery_and_request_uri (yes, I know i am not brilliant at names)?

I would also borrow some language from https://www.rfc-editor.org/rfc/rfc9101#section-5-2.4 like

Suggested change

`presentation_request_uri`:

: A string containing an HTTPS URL pointing to a resource under the control of the Verifier where the Wallet is supposed to obtain the presentation request object.

`presentation_request_uri`:

: The absolute URI, as defined by [RFC 3986](https://www.rfc-editor.org/rfc/rfc9101#RFC3986) [[RFC3986](https://www.rfc-editor.org/rfc/rfc9101#RFC3986)], that receives data from the Wallet such as endpoint, capabilities and attestation and returns the [Request Object](https://www.rfc-editor.org/rfc/rfc9101#name-request-object) containing the authorization request parameters defined in [Section 5](https://openid.bitbucket.io/connect/openid-4-verifiable-presentations-1_0.html#section-5).

not sure we need If this parameter is present in the authorization request, request MUST NOT be present.

I'm not in favor of discovery AND request, since I assume that there might be cases where a wallet solution doesn't support the discovery feature then the request_uri endpoint should be untouched

I assume, according to my implementations, that the RP that can't assert the wallet capabilities should attests to the wallet instance the lowest level of security, if supported for the requirements of the LoA, and using a standard/defined/wellknown and common capabilities for the wallet ecosystems

The idea in the PR is to have a new endpoint (the presentation endpoint) that bundles discovery and request creation. We could also split this into discovery and request_uri. However I would like to understand the consequences. What directly comes to mind is that the state must be kept at the verifier between the two requests whereas the current design allows the verifier to create the request and directly release it to the wallet.

@Sakurann I suggest to call it fetch_presentation_request_uri (see my comment further up) as the current name is not correct.

I'm for discovery_response_uri where the HTTP response could be 302 Found with the discovery_state that binds the discovery to the request issuance

then we have divided the endpoints by using the request_uri endpoint with the sole addition of the discovery_state that allows the RP to do its lookups. This value could be also encrypted (depending by what would cost more in an infrastructure: CPU or Storage!)

Sakurann · 2023-10-03T19:09:47Z

openid-4-verifiable-presentations-1_0.md

+`context`:
+: A string identifying the context of the discovery request from the perspective of the Verifier. The value is opqaue to the Wallet, it MUST pass this value to the Presentation Endpoint Request (see below). 


I think it is best to avoid using a term context in anything issuer-holder-verifier model related... (because it has a very specific meaning in w3c vcdm)

Suggested change

`context`:

: A string identifying the context of the discovery request from the perspective of the Verifier. The value is opqaue to the Wallet, it MUST pass this value to the Presentation Endpoint Request (see below).

`verifier_state`:

: A value opaque to the Wallet used by the Verifier to maintain state between discovery request and response. When received, the Wallet MUST pass this value to the Presentation Endpoint.

I intentionally did not designate it as state as it is intended to be used to label the context ("entrance to east wing") and not carry a certain state of a certain transaction. This allows to use the same discovery request for multiple transactions (print it out and put it onto the wall).

I think it is good to use something distinct from state (and I agree with Torsten's arguments). context feels ok to me.

I fully agree with Kristina, context is something too much related to other specs and schemas.
I propose discovery_state with the will to keep the words always on the same direction, the good semantic help us to reduce the brain stress

Sakurann · 2023-10-03T19:10:29Z

openid-4-verifiable-presentations-1_0.md

+```JSON
+{
+    "presentation_request_uri": "verifier.example.com/presentation_request",
+    "context": "register_kyc"
+}
+```


just to note that parameter names might change based on the comments above.

openid-4-verifiable-presentations-1_0.md

Sakurann · 2023-10-03T19:13:01Z

openid-4-verifiable-presentations-1_0.md

+
+Note: the Discovery Request intentionally does not use OAuth parameters, such as a `client_id`. The idea is to allow the Verifier to select the Client Identifier it wants to use for interacting with the Wallet after it has determined the trust mechanisms and domains the wallet supports.   
+
+## Discovery Endpoint


I think this section needs to be in the Verifier Metadata section https://openid.bitbucket.io/connect/openid-4-verifiable-presentations-1_0.html#name-wallet-metadata-authorizati and not here

This endpoint is not the typical static "get some metadata" endpoint. It is part of the application logic of the wallet. I therefore added it here. I think this is the best solution for readability and understandability.

openid-4-verifiable-presentations-1_0.md

Co-authored-by: Giuseppe De Marco <[email protected]>

…nto advanced_flow

tlodderstedt · 2023-10-16T14:55:55Z

context renamed to discovery_state (since it is opaque to the wallet instance) or discovery_session, or discovery_context

I would like to avoid parameter names causing the impression this parameter should be transaction specific. My idea is to allow for static values so this request could be printed out and put on a wall. The context shall then identify the place where the verifier wants to use the VP. I changed the name to interaction.

presentation_uri renamed to protected_request_uri (since it is protected and ruterns 401 if WIA is not provided)

protected is pretty generic and holds true for a lot of HTTPS resources

wallet instance metadata can be obtained in several ways -> optional, depends by trust and interop model

I added text saying metadata MAY be obtained from the AS metadata, but they MAY also be obtained by other means, e.g. as part of the wallet attestation

tlodderstedt · 2023-10-16T15:14:33Z

@peppelinux @paulbastian @David-Chadwick @danielfett

It seems the most significant issue right now is the question whether the wallet should send data to the verifier before the verifier is authenticated.

I see the following options:

Option 1: sign the discovery request: that is feasible from a technical standpoint. However, what scheme, what trust framework, and which key should the verifier use? The design assume the verifier will have the require data provided in the presentation request. This allows multi homing verifiers, those connected to a US, a EU, and a JP trust framework.

Option 2: leave the protocol as is and add privacy considerations recommending a user gesture before the presentation request is sent to the verifier (e.g. the unlock of the wallet). That would at least prevent silent finger printing.

Option 3: send minimal data to the presentation endpoint, e.g. static profile data. Wallet authentication might happen at the direct post.

Please let me know what you think.

peppelinux · 2023-10-16T16:57:04Z

@tlodderstedt

I changed the name to interaction.

at least discovery_interaction! :-)

protected is pretty generic and holds true for a lot of HTTPS resources

presentation_uri is generic as well since it represents a single endpoint of the entire presentation flow.
I would say that protected_request_uri refers to the presentation request, would it be then presentation_protected_request_uri?

I added text saying metadata MAY be obtained from the AS metadata, but they MAY also be obtained by other means, e.g. as part of the wallet attestation

That's good. Because we assume that a specific wallet instance installed on a specific hardware may support a subset of algs supported by wallet solution. Therefore, the Wallet Solution may issue a specific Wallet Instance Attestation containing the tailored capabilities regarding a specific wallet instance.

Option 1: sign the discovery request

I'm in favor of this. The issue of selecting the trust framework is common to all the signed attestations defines in the OpenID4VC suite. Then I would not see this issue for this flow in particular and I would suggest to keep this out of the scope of this PR.

Option 2

Too weak from my perspective, since users must be "protected" by their wallet instance.

Option 3

I would say that this would be too late for the RP, because it should not sign nothing or evaluate nothing before having attested the reliability of the wallet instance, considering also that the wallet capabilities may be provided within the wallet instance attestation, that's the scope of the current PR (Providing the wallet instance attestation before the issuance of RP's signed request).

David-Chadwick · 2023-10-17T09:52:35Z

@tlodderstedt It seems the most significant issue right now is the question whether the wallet should send data to the verifier before the verifier is authenticated.
This was at the heart of the issue I originally raised on the OID4VP spec over a year ago, but I phrased it rather differently, viz: "the wallet should not send any data to the verifier until it knows the verifier can be trusted". ( I believe this resulted in the client_id_scheme being added to the VP protocol, which I said at the time I did not think was sufficient for engendering trust in the verifier.)
Determining if the verifier is trusted is different from authenticating the verifier, because an authenticated verifier may still not be trustworthy. OTOH, a wallet/holder can still determine if an unauthenticated verifier's purported identity is trustworthy or not. This was the approach we took in our implementation, which I will repeat here for critical appraisal.

The verifier asserts its identity (it can be true or a lie, it does not matter)
The wallet/holder determines if the asserted identity is trustworthy or not
If the verifier's asserted identity is deemed to be trustworthy by the trust infrastructure that the wallet use (or if the user decides to risk progressing with an untrustworthy verifier) then the transaction can continue
The wallet downloads the metadata of the asserted identity from its well known endpoint. If the verifier did not lie about its identity then its metadata will be obtained, otherwise that of a trustworthy verifier will be.
Now the wallet will continue to communicate with the entity whose identity was originally communicated to it, which may or may not be with the original verifier. In the latter case the communication will presumably soon cease!

decentralgabe · 2023-10-17T16:34:19Z

openid-4-verifiable-presentations-1_0.md

@@ -126,7 +126,9 @@ This specification supports any Credential format used in the Issuer-Holder-Veri

 Implementations can use any pre-existing OAuth 2.0 Grant Type and Response Type in conjunction with this specification to support different deployment architectures.

-OpenID for Verifiable Presentations supports scenarios where the Authorization Request is sent both when the Verifier is interacting with the End-User using the device that is the same or different from the device on which requested Credential(s) are stored.
+OpenID for Verifiable Presentations supports scenarios where the Authorization Request is sent both when the Verifier is interacting with the End-User using the device that is the same or different from the device on which requested Credential(s) are stored. 


Suggested change

OpenID for Verifiable Presentations supports scenarios where the Authorization Request is sent both when the Verifier is interacting with the End-User using the device that is the same or different from the device on which requested Credential(s) are stored.

OpenID for Verifiable Presentations supports the scenario in which the Verifier sends an Authorization Request to an End-User using either the same or different device from which the requested Credential(s) are stored.

how's this?

tlodderstedt · 2023-10-17T19:28:47Z

@David-Chadwick what is your opinion on the three options I proposed?

David-Chadwick · 2023-10-17T20:29:20Z

@tlodderstedt My opinion is that none of the solutions are optimum because they are not addressing the critical issue, which is "is the verifier trusted". So none of your solutions are what is actually needed. I gave you a much longer answer above explaining why authenticating the verifier is not sufficient, because an authenticated crook is still a crook.
However, authenticating the verifier can help because then the holder/wallet will not necessarily need to fetch the metadata from the well known endpoint. So 1 is the best of the three, providing that after authentication, the holder/wallet then continues to determine if this verifier is trusted before returning any information to it.

paulbastian · 2023-10-18T08:00:38Z

@peppelinux @paulbastian @David-Chadwick @danielfett

It seems the most significant issue right now is the question whether the wallet should send data to the verifier before the verifier is authenticated.

I see the following options:

Option 1: sign the discovery request: that is feasible from a technical standpoint. However, what scheme, what trust framework, and which key should the verifier use? The design assume the verifier will have the require data provided in the presentation request. This allows multi homing verifiers, those connected to a US, a EU, and a JP trust framework.

Option 2: leave the protocol as is and add privacy considerations recommending a user gesture before the presentation request is sent to the verifier (e.g. the unlock of the wallet). That would at least prevent silent finger printing.

Option 3: send minimal data to the presentation endpoint, e.g. static profile data. Wallet authentication might happen at the direct post.

Please let me know what you think.

Option 1 looks pretty ugly to me and we have 2 steps of Verifier authentication.
Option 2 is likely to be implemented wrong or may result to double user consent.
I favor Option 3. It changes as few things as possible and gives enough benefits in my opinion while ensuring privacy.

tlodderstedt · 2023-10-20T06:57:49Z

Hi all, in the WG call yesterday we felt it is best to go one step back and decide whether we want to fulfill the following requirement.

Should the protocol allow the verifier to pick client id scheme and credentials based on the data received from the wallet in the presentation request (step 4 in the sequence diagram)?

This requirement determines whether authentication (and further steps) can be done in the initial discovery request or not.

Please share your opinion.

David-Chadwick · 2023-10-20T12:54:24Z

My opinion is that the discovery request message should provide enough information for the user's device to determine if the verifier's asserted name/id can be trusted or not, based on information provided in the discovery request message (which does not need to be authenticated).

tlodderstedt · 2023-10-20T16:30:15Z

@David-Chadwick would you assume the verifier provide different identifers? I'm asking since the client could use different identifiers in different trust frameworks.

bc-pi · 2023-10-20T20:02:47Z

On the Thurs call Torsten suggested that wallet authentication/attestation wasn't need in the presentation flow (which I think I agree with) but that some kind of attestation might be necessary with SIOP for user authentication. That suggests that whatever attestation is needed there should be added in SIOP (maybe part of the id token) but not be part of this work/design.

David-Chadwick · 2023-10-21T07:49:03Z

@tlodderstedt The verifier should know what trust frameworks it is registered in (at least this is a reasonable assumption to make, because there will be some rules that the verifier will have to conform to in order to be recognised as trusted by each framework). So the verifier can send its registered id/names in the discovery request message, as well as the IDs of the trust frameworks (which will need to be globally unique, so URLs could be mandated for these).
The wallet then looks at the sent trust frameworks, see which one(s) it recognises, and then ask it(them) if the provided verifier id/name is trusted. Once the wallet has its answer(s) it can progress from there. This is what we implemented.

peppelinux · 2023-10-21T11:42:39Z

@bc-pi following the friday call with @paulbastian and Franceco Marino I bring here the points about the requirement, from the RP perspective, of obtaining the wallet instance attestation and capabilities before issuing the request object

With the will of using both openidvp and siopv2 in a single implementation I suggest to work on a flow that would not introduce too many differences between the two specs. I take into account that the pseudonym authentication should be made with siopv2 id_token and that a user would be able to get authenticated using a pseudonym, instead of presenting a digital credential. For this reason I suggest to keep siopv2 and openid4vp as close as possible, reducing any implementation delta;
Considering that the wallet instance supports sign alg B and the RP supports sign algs A, B and C, the RP should know the wallet instance capabilities, through the discovery flow, to sign the request object using the alg B, otherwise it would use by default A and then B and C would not never used, or randomly used. This explain well why the RP should know the capabilities of the wallet instance it is interacting with. I would exclude in this analysis the elusive opportunity to not sign the request object, since the signature of the request object is required by several wallet ecosystem trust models (at least EUDI Wallet);
The RP that provides to the wallet instance a URL, within a qrcode for cross device or within a redirect (302 Location URL) within the same device flow, should know the wallet instance's authorization_endpoint. The authorization_endpoint could be a custom url-scheme or an universal link registered within the user mobile device and using general purpose values could raise cross-app security issues; if the user uses the device camera for framing the qr-code and then the request_uri would be processed with a wrong (or colliding) mobile application that's not the one used for the digital identities or specific purposes. For this reason the RP should know the authorization_endpoint of the wallet instance to be sure to ask the interaction with the proper mobile application installed into the user's mobile device;
A wallet instance that not provides the wallet instance attestation or an expired wallet instance attestation in the presentation response would fail the authentication to the RP. Why we're designing a flow that introduce this possibility? I believe it is valuable for a good user experience to have the discovery of capabilities before the authentication and presentation of personal data takes place, this allows us to save time and resources for both the user and the RP. Think of attacks based on the use of fake encrypted presentations. The RP would find itself consuming resources, decrypting and subsequently failing to validate the signature and contents, when rather discovery concentrates the resources between the parties in a single objective, that of establishing trust and capabilities, before authentication occurs . This also offers a good division of discovery and authentication purposes, which if it were united and monolithic in the presentation response would bring greater risks to the RP, such as attacks based on resource consumption (CPU) as described in this point.
Wallet instance may have response_modes_supported in its capabilities and not supporting the http redirects (302 found), but form_post and/or form_post.jwt

openid-4-verifiable-presentations-1_0.md

Co-authored-by: Brian Campbell <[email protected]>

jruizaranguren · 2023-10-31T13:13:43Z

Following the call last wednesday 25th, in some of the proposals there was a need to communicate capabilities or features by at least one of the participants in an exchange:

the verifier publishes its capabilities / features over trust frameworks, so a holder can decide if it can fullfil the requirements of that verifier per feature.
the holder publishes its capabilites so a verifier can offer presentation definitions tailored to the capabilities of the wallet.

With independence of which option satisfies privacy or functional concerns, in both cases the specification of capabilities / features must be advertised by one or both participants. Is there any previous attempt to describe such a thing? I'm verifier X, registered in Y and Z trust framework using W means, and offer the following A, B, C, exchanges using these methods, algorithms, credential formats, etc.

tlodderstedt · 2023-11-02T18:04:25Z

Hi all, I filed a new PR with an alternative design for the advanced flow. It is less sophisticated but simpler and more privacy preserving. I hope it can be the basis of a consensus. Have a look at PR #59.

@peppelinux @paulbastian @David-Chadwick @danielfett @Sakurann

awoie · 2023-11-27T22:43:47Z

Hi all, I filed a new PR with an alternative design for the advanced flow. It is less sophisticated but simpler and more privacy preserving. I hope it can be the basis of a consensus. Have a look at PR #59.

@peppelinux @paulbastian @David-Chadwick @danielfett @Sakurann

In general I'm supportive of the flow described in #59. Personally, I think we should also include the approach that was described in #65 to allow wallets to detect phishing attacks.

peppelinux · 2024-01-08T20:03:17Z

@tlodderstedt may we close this PR since it is overseeded by #59?

PR 59 references this PR as well

tlodderstedt · 2024-01-18T01:39:29Z

Closing this PR as the WG is pursuing a different design proposed in PR #59

tlodderstedt added 3 commits September 27, 2023 10:18

added sequence diagram

55d221f

first draft of the advanced flow

b3dbced

discovery example

f261533

tlodderstedt mentioned this pull request Sep 27, 2023

Advanced flow for OpenID4VP #45

Closed

peppelinux requested changes Sep 27, 2023

View reviewed changes

Sakurann reviewed Sep 28, 2023

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

Sakurann reviewed Sep 28, 2023

View reviewed changes

peppelinux mentioned this pull request Oct 2, 2023

Refinement of the presentation phase flow italia/eudi-wallet-it-docs#114

Closed

Sakurann requested review from danielfett, jogu, awoie and bc-pi October 3, 2023 05:33

Sakurann reviewed Oct 3, 2023

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

Sakurann reviewed Oct 3, 2023

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

Sakurann reviewed Oct 3, 2023

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

Sakurann reviewed Oct 3, 2023

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

Sakurann reviewed Oct 3, 2023

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

Sakurann reviewed Oct 3, 2023

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

tlodderstedt and others added 3 commits October 16, 2023 16:50

Update openid-4-verifiable-presentations-1_0.md

a25840a

Co-authored-by: Giuseppe De Marco <[email protected]>

changed context to interaction

0a85508

Merge branch 'advanced_flow' of https://github.com/openid/OpenID4VP i…

32259a1

…nto advanced_flow

decentralgabe reviewed Oct 17, 2023

View reviewed changes

peppelinux mentioned this pull request Oct 23, 2023

OpenID4VP pending issues italia/eudi-wallet-it-docs#34

Closed

5 tasks

bc-pi reviewed Oct 25, 2023

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

Update openid-4-verifiable-presentations-1_0.md

e8f97ac

Co-authored-by: Brian Campbell <[email protected]>

tlodderstedt removed the priority label Dec 21, 2023

tlodderstedt closed this Jan 18, 2024

tlodderstedt reopened this Jan 18, 2024

tlodderstedt closed this Jan 18, 2024

awoie mentioned this pull request Mar 1, 2024

Signed Requests and Replay Prevention #4

Closed

		@@ -215,6 +215,53 @@ Figure: Cross Device Flow

		(3) The Wallet prepares the Verifiable Presentation(s) of the Verifiable Credential(s) that the End-User has consented to. It then sends to the Verifier an Authorization Response where the Verifiable Presentation(s) are contained in the `vp_token` parameter.

		## Advanced Flow with Wallet Capabilities Discovery {#adv_flow}

	## Advanced Flow with Wallet Capabilities Discovery {#adv_flow}
	## Cross Device Flow with Wallet Capabilities Discovery {#adv_flow}

	\| \| (2) Request the Request Object \|
	\| \| (2) Discovery Response \|
	\| \|(Wallet's endpoint, capabilities, Attestation, etc)\|

		`presentation_request_uri`:
		: A string containing an HTTPS URL pointing to a resource under the control of the Verifier where the Wallet is supposed to obtain the presentation request object.

		`context`:
		: A string identifying the context of the discovery request from the perspective of the Verifier. The value is opqaue to the Wallet, it MUST pass this value to the Presentation Endpoint Request (see below).


		Note: the Discovery Request intentionally does not use OAuth parameters, such as a `client_id`. The idea is to allow the Verifier to select the Client Identifier it wants to use for interacting with the Wallet after it has determined the trust mechanisms and domains the wallet supports.

		## Discovery Endpoint

	OpenID for Verifiable Presentations supports scenarios where the Authorization Request is sent both when the Verifier is interacting with the End-User using the device that is the same or different from the device on which requested Credential(s) are stored.
	OpenID for Verifiable Presentations supports the scenario in which the Verifier sends an Authorization Request to an End-User using either the same or different device from which the requested Credential(s) are stored.

Advanced flow #52

Advanced flow #52

Conversation

tlodderstedt commented Sep 27, 2023 • edited Loading

peppelinux commented Sep 27, 2023

peppelinux left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bc-pi Oct 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bc-pi Oct 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peppelinux commented Sep 29, 2023 • edited Loading

peppelinux commented Sep 29, 2023 • edited Loading

Sakurann Oct 3, 2023 • edited Loading

Choose a reason for hiding this comment

Sakurann Oct 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sakurann Oct 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tlodderstedt Oct 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peppelinux Oct 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tlodderstedt commented Oct 16, 2023

tlodderstedt commented Oct 16, 2023

peppelinux commented Oct 16, 2023

David-Chadwick commented Oct 17, 2023

Choose a reason for hiding this comment

tlodderstedt commented Oct 17, 2023

David-Chadwick commented Oct 17, 2023 • edited Loading

paulbastian commented Oct 18, 2023

tlodderstedt commented Oct 20, 2023

David-Chadwick commented Oct 20, 2023

tlodderstedt commented Oct 20, 2023

bc-pi commented Oct 20, 2023

David-Chadwick commented Oct 21, 2023

peppelinux commented Oct 21, 2023 • edited Loading

jruizaranguren commented Oct 31, 2023 • edited Loading

tlodderstedt commented Nov 2, 2023 • edited Loading

awoie commented Nov 27, 2023

peppelinux commented Jan 8, 2024

tlodderstedt commented Jan 18, 2024

tlodderstedt commented Sep 27, 2023 •

edited

Loading

peppelinux left a comment •

edited

Loading

bc-pi Oct 3, 2023 •

edited

Loading

bc-pi Oct 3, 2023 •

edited

Loading

peppelinux commented Sep 29, 2023 •

edited

Loading

peppelinux commented Sep 29, 2023 •

edited

Loading

Sakurann Oct 3, 2023 •

edited

Loading

Sakurann Oct 3, 2023 •

edited

Loading

Sakurann Oct 3, 2023 •

edited

Loading

tlodderstedt Oct 4, 2023 •

edited

Loading

peppelinux Oct 4, 2023 •

edited

Loading

David-Chadwick commented Oct 17, 2023 •

edited

Loading

peppelinux commented Oct 21, 2023 •

edited

Loading

jruizaranguren commented Oct 31, 2023 •

edited

Loading

tlodderstedt commented Nov 2, 2023 •

edited

Loading