add security consideration on incomplete or incorrect implementation of the specification #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
requested review from
danielfett,
jogu,
tlodderstedt,
selfissued,
c2bo,
tplooker,
paulbastian,
awoie and
bc-pi
jogu
approved these changes
Dec 19, 2024
paulbastian
reviewed
Jan 9, 2025
| @@ -1614,6 +1614,14 @@ Implementations MUST follow [@!BCP195]. | |||
|
|
|||
| Whenever TLS is used, a TLS server certificate check MUST be performed, per [@!RFC6125]. | |||
|
|
|||
| ## Incomplete or Incorrect Implementation of the Specifications and Conformance Testing | |||
|
|
|||
| To achieve the full security benefits, it is important the implementation of this specification, and the underlying specifications, are both complete and correct. | |||
There was a problem hiding this comment.
Suggested change
| To achieve the full security benefits, it is important the implementation of this specification, and the underlying specifications, are both complete and correct. | |
| To achieve the full security benefits, it is important that the implementation of this specification, and the underlying specifications, are both complete and correct. |
paulbastian
approved these changes
Jan 9, 2025
c2bo
approved these changes
Jan 10, 2025
| @@ -1614,6 +1614,14 @@ Implementations MUST follow [@!BCP195]. | |||
|
|
|||
| Whenever TLS is used, a TLS server certificate check MUST be performed, per [@!RFC6125]. | |||
|
|
|||
| ## Incomplete or Incorrect Implementation of the Specifications and Conformance Testing | |||
There was a problem hiding this comment.
Suggested change
| ## Incomplete or Incorrect Implementation of the Specifications and Conformance Testing | |
| ## Incomplete or Incorrect Implementations of the Specifications and Conformance Testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there have been requests to mention conformance tests in the specification to make them more visible.
Modeling this PR after https://openid.net/specs/openid-financial-api-part-2-1_0.html#incomplete-or-incorrect-implementations-of-the-specifications
resolves #366.