Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dcql in #browser_api_request example rather than pe #294

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

bc-pi
Copy link
Member

@bc-pi bc-pi commented Oct 23, 2024

Use dcql in #browser_api_request example rather than pe, which is an editorial change to a non-normative example that maybe kinda should have gone in https://github.com/openid/OpenID4VP/pull/254/files#r1811264551

Copy link
Contributor

@samuelgoto samuelgoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be much appreciated by browser vendors ... much simpler to understand the dcql_query than PE ...

Any chance we can make this required, so that browser vendors don't have to parse/support both?

@jogu jogu added documentation Improvements or additions to documentation editorial labels Oct 29, 2024
@jogu
Copy link
Collaborator

jogu commented Oct 29, 2024

I think this would be much appreciated by browser vendors ... much simpler to understand the dcql_query than PE ...

Any chance we can make this required, so that browser vendors don't have to parse/support both?

Can you open an issue for this please Sam, if we don't already have one? If we have sufficient implementation experience it's definitely something we could ask the working group about before 1.0.

@jogu
Copy link
Collaborator

jogu commented Oct 29, 2024

Editorial, 4 approvals, merging.

@jogu jogu merged commit 5f76448 into main Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation editorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants